[git] GpgOL - branch, master, updated. gpgol-1.4.0-202-gdff5213

[by Andre Heinecke]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GnuPG extension for MS Outlook".

The branch, master has been updated
       via  dff5213c6a57984c3a06d2d0289697ffbf872950 (commit)
       via  fd7d8e2325a08695838b9ba217bbd57066822a1f (commit)
      from  589fc6d790969979d2ae1c0e2c947967241d7741 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dff5213c6a57984c3a06d2d0289697ffbf872950
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Thu Dec 1 17:13:14 2016 +0100

    Add supertip for unsigned messages
    
    * src/ribbon-callbacks.cpp (get_sig_stip): Handle mail not found
    case.
    
    --
    Mail not found means no crypto mail

diff --git a/src/ribbon-callbacks.cpp b/src/ribbon-callbacks.cpp
index 59afca1..374885d 100644
--- a/src/ribbon-callbacks.cpp
+++ b/src/ribbon-callbacks.cpp
@@ -1567,7 +1567,7 @@ HRESULT get_sig_ttip (LPDISPATCH ctrl, VARIANT *result)
     }
   else
     {
-      w_result = utf8_to_wchar (_("This message is not cryptographically signed"));
+      w_result = utf8_to_wchar (_("This message is not cryptographically signed."));
     }
   result->bstrVal = SysAllocString (w_result);
   xfree (w_result);
@@ -1583,7 +1583,10 @@ HRESULT get_sig_stip (LPDISPATCH ctrl, VARIANT *result)
     {
       log_debug ("%s:%s: No mail.",
                  SRCNAME, __func__);
-      result->bstrVal = SysAllocString (L"");
+      wchar_t *w_result;
+      w_result = utf8_to_wchar (_("You cannot be sure who wrote the message."));
+      result->bstrVal = SysAllocString (w_result);
+      xfree (w_result);
       return S_OK;
     }
   const auto message = mail->get_signature_status ();

commit fd7d8e2325a08695838b9ba217bbd57066822a1f
Author: Andre Heinecke <aheinecke at intevation.de>
Date:   Thu Dec 1 17:09:30 2016 +0100

    Fix crash when viewing unsigned mails
    
    * src/ribbon-callbacks.cpp (get_sig_label): Return early
    if mail not found.
    
    --
    Ooops. Although it could be considered a security feature ;-)

diff --git a/src/ribbon-callbacks.cpp b/src/ribbon-callbacks.cpp
index f02ab89..59afca1 100644
--- a/src/ribbon-callbacks.cpp
+++ b/src/ribbon-callbacks.cpp
@@ -1525,6 +1525,10 @@ HRESULT get_sig_label (LPDISPATCH ctrl, VARIANT *result)
     {
       log_debug ("%s:%s: No mail.",
                  SRCNAME, __func__);
+      w_result = utf8_to_wchar (_("Not Trusted"));
+      result->bstrVal = SysAllocString (w_result);
+      xfree (w_result);
+      return S_OK;
     }
   bool valid = mail->is_valid_sig ();
   const auto pair = mail->get_valid_sig ();

-----------------------------------------------------------------------

Summary of changes:
 src/ribbon-callbacks.cpp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GnuPG extension for MS Outlook
http://git.gnupg.org