Bug in keyserver code: DOS line endings

David Shaw dshaw at jabberwocky.com
Wed Jun 12 23:24:01 CEST 2002

On Wed, Jun 12, 2002 at 03:10:19PM -0500, Keith Ray wrote:
> > Aside from this problem, does it work all right on Win32?
> Once I applied the above patch and the fix for the input and output
> tempfile being the same, it appears to work well.  Proxying doesn't seem
> to work, but I consider that minor.

Be careful with your patch - it has a potential buffer overrun in it.
I have a different fix in the CVS version.

> Also, this line doesn't work either due to the same reason:
> keyserver.c:483
> line[strlen(line)-1]='\0';

Ok, I'll fix this.

> One last thing, can you please #ifdef unistd.h with HAVE_UNISTD_H?

There are 18 includes of <unistd.h> in GnuPG.  Why is this one a


   David Shaw  |  dshaw at jabberwocky.com  |  WWW http://www.jabberwocky.com/
   "There are two major products that come out of Berkeley: LSD and UNIX.
      We don't believe this to be a coincidence." - Jeremy S. Anderson

More information about the Gnupg-devel mailing list