[PATCH] fix a typo when building libgcrypt and gnupg 1.4 with mingw-runtime 3.10

Rafaël Carré funman at videolan.org
Thu Nov 2 21:17:00 CET 2006


Hello,

Since version 3.10, mingw-runtime now includes gettimeofday() defined
in <sys/time.h> as specified by POSIX:
http://www.opengroup.org/onlinepubs/009695399/functions/gettimeofday.html

People using this version to compile are experiencing problems with a
piece of code which is common to gnupg 1.4 and libcrypt 1.2.3 :
cipher/random.c
http://lists.gnupg.org/pipermail/gnupg-devel/2006-June/022975.html

Here is that code:

#ifdef HAVE_GETTIMEOFDAY
#include <sys/times.h>
#endif

What will happen on UNIX systems: they all have gettimeofday(), and they
all have sys/times.h so it's ok

What will happen on WINDOWS systems: they don't have gettimeofday() , so
it's ok too

What will happen on WINDOWS systems using mingw compiler and
mingw-runtime 3.10 : they have gettimeofday(), but they don't have
<sys/times.h> so the build will fail

To my knowledge, there is no system that defines gettimeofday() in
<sys/times.h>, only in <sys/time.h>

Please replace <sys/times.h> by <sys/time.h> because this is an
annoying typo.

Thanks.

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/attachments/20061102/3223c3aa/signature-0001.pgp


More information about the Gnupg-devel mailing list