[PATCH Libgpg-error] m4: Fix detection of gpgrt's libdir.

[Todd Zullinger]

Jeffrey Walton via Gnupg-devel wrote:
> On Tue, Sep 20, 2022 at 5:29 PM Damien Goutte-Gattat via Gnupg-devel
> <gnupg-devel at gnupg.org> wrote:
...
>> diff --git a/src/gpg-error.m4 b/src/gpg-error.m4
>> index 4b5cd40..a9b96af 100644
>> --- a/src/gpg-error.m4
>> +++ b/src/gpg-error.m4
>> @@ -120,6 +120,10 @@ AC_DEFUN([AM_PATH_GPG_ERROR],
>>          fi
>>          if test -n "$gpgrt_libdir"; then break; fi
>>        done
>> +      if test -z "$libdir_candidates"; then
>> +        # No valid pkgconfig dir in any of the system directories, fallback
>> +        gpgrt_libdir=${possible_libdir1}
>> +      fi
>>      else
>>        # When we cannot determine system libdir-format, use this:
>>        gpgrt_libdir=${possible_libdir1}
...
> I think the portable test is:
> 
>     if test x"$libdir_candidates" = "x"; then
> 
> I don't recall why it is preferred.

This came up on the git list about a year ago.  The git
project tries quite hard to write portable shell code and
they don't require the `test "x$foo" = "x"` idiom.

    https://lore.kernel.org/git/3ab4f29e-987a-c7de-0cca-a64c3bf4be47@gmail.com/

That post links to an interesting article on the history of
this particular shell idiom:

    https://www.vidarholen.net/contents/blog/?p=1035

Based on that, I think it would be better to not use that
method unless the reason for it can be adequately defined.

-- 
Todd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 543 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20220921/bfce2cbc/attachment.sig>