[gnutls-dev] Re: prototype shadowing warning
jas at extundo.com
Sat Feb 12 16:51:02 CET 2005
Neil Spring <nspring at cs.washington.edu> writes:
> Please avoid using "index", "time" and "exp" as parameter names in
> function prototypes in header files to avoid -Wshadow warnings.
> Warnings follow. (yeah, I know the compiler should be a little smarter,
> but then again, "index" and "time" aren't very descriptive names for
> Sorry I'm so picky.
Not at all, I agree completely.
Should be fixed in CVS now, please verify.
I have added -Wshadow to the CFLAGS that are added by
--enable-developer-mode. Hopefully I (or someone else) will get
annoyed at the warnings and fix them eventually, there were quite a
few of them. Further, the function prototypes seem to be duplicated
in several places in includes/gnutls/ and lib/, I think we should try
to only have function prototypes in one place. It is less work to
maintain all copies.
More information about the Gnutls-dev