From ciprian.craciun at gmail.com Sun Jun 15 12:46:44 2008 From: ciprian.craciun at gmail.com (Ciprian Dorin Craciun) Date: Sun, 15 Jun 2008 13:46:44 +0300 Subject: configure option to disable tests Message-ID: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> Hello all! I'm writing this to make a small suggestion: it would be nice to have an option to disable the tests when building and installing. I'm asking this because I want to install libgcrypt to a non-standard location (ex. /packages/libgcrypt--1.4.1), and after installing it I want to symlink all includes and libs into /packages/.include /packages/.lib, but the tests fail by not finding the includes and libs (as they haven't been symlink-ed yet). Thanks all, Ciprian Craciun. From simon at josefsson.org Sun Jun 15 19:58:28 2008 From: simon at josefsson.org (Simon Josefsson) Date: Sun, 15 Jun 2008 19:58:28 +0200 Subject: configure option to disable tests In-Reply-To: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> (Ciprian Dorin Craciun's message of "Sun, 15 Jun 2008 13:46:44 +0300") References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> Message-ID: <877icq4m2j.fsf@mocca.josefsson.org> "Ciprian Dorin Craciun" writes: > Hello all! > > I'm writing this to make a small suggestion: it would be nice to > have an option to disable the tests when building and installing. > > I'm asking this because I want to install libgcrypt to a > non-standard location (ex. /packages/libgcrypt--1.4.1), and after > installing it I want to symlink all includes and libs into > /packages/.include /packages/.lib, but the tests fail by not finding > the includes and libs (as they haven't been symlink-ed yet). Normally, self-tests doesn't require the program to be installed at all. What errors do you get? /Simon From simon at josefsson.org Mon Jun 16 01:18:14 2008 From: simon at josefsson.org (Simon Josefsson) Date: Mon, 16 Jun 2008 01:18:14 +0200 Subject: configure option to disable tests In-Reply-To: <8e04b5820806151505o6a621e6btd2283ea2af94aacb@mail.gmail.com> (Ciprian Dorin Craciun's message of "Mon, 16 Jun 2008 01:05:01 +0300") References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> <877icq4m2j.fsf@mocca.josefsson.org> <8e04b5820806151505o6a621e6btd2283ea2af94aacb@mail.gmail.com> Message-ID: <87k5gq1e4p.fsf@mocca.josefsson.org> "Ciprian Dorin Craciun" writes: > [oo] Making install in tests > [oo] make[1]: Entering directory `/tmp/vpm--1213567395239134476/output/tests' > [oo] /bin/sh ../libtool --tag=CC --mode=link gcc -I/packages/libgpg-error--1.6/include -g -O2 -fvisibility=hidden -Wall -Wpointer-arith -L/packages/.lib -o ac-schemes ac-schemes.o ../src/libgcrypt.la > [oo] gcc -I/packages/libgpg-error--1.6/include -g -O2 -fvisibility=hidden -Wall -Wpointer-arith -o .libs/ac-schemes ac-schemes.o -L/packages/.lib ../src/.libs/libgcrypt.so -Wl,--rpath -Wl,/packages/libgcrypt--1.4.1/lib > [ee] ac-schemes.o: In function `scheme_get_opts': > [ee] /tmp/vpm--1213567395239134476/sources/tests/ac-schemes.c:87: undefined reference to `gpg_err_code_from_errno' > [ee] collect2: ld returned 1 exit status > [ee] make[1]: *** [ac-schemes] Error 1 > [ee] make: *** [install-recursive] Error 1 > [oo] make[1]: Leaving directory `/tmp/vpm--1213567395239134476/output/tests' > [XX] => failed; > [XX] => failing; Could the -fvisibility=hidden be your problem? The self tests call functions in libgpg-error, but it is only linked against libgcrypt. Libgcrypt links to libgpg-error, so normally it would work. /Simon From wk at gnupg.org Mon Jun 16 10:19:28 2008 From: wk at gnupg.org (Werner Koch) Date: Mon, 16 Jun 2008 10:19:28 +0200 Subject: configure option to disable tests In-Reply-To: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> (Ciprian Dorin Craciun's message of "Sun, 15 Jun 2008 13:46:44 +0300") References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> Message-ID: <87zlpl94hb.fsf@wheatstone.g10code.de> On Sun, 15 Jun 2008 12:46, ciprian.craciun at gmail.com said: > I'm asking this because I want to install libgcrypt to a > non-standard location (ex. /packages/libgcrypt--1.4.1), and after > installing it I want to symlink all includes and libs into > /packages/.include /packages/.lib, but the tests fail by not finding > the includes and libs (as they haven't been symlink-ed yet). It would be easier if you install the final packages (well the symlinks) int /packages/{include,lib,bin}. This can be done by using: ./configure --prefix=/packages make make install prefix=/packages/libgcrypt--1.4.1 In your case you need to run configure with something like ./configure --bindir=/packages/.bin --libdir=/packages/.lib ..... and quite some more options. Check out ./configure --help. The make invocations are still as show above. Salam-Shalom, Werner -- Die Gedanken sind frei. Auschnahme regelt ein Bundeschgesetz. From ciprian.craciun at gmail.com Mon Jun 16 00:05:01 2008 From: ciprian.craciun at gmail.com (Ciprian Dorin Craciun) Date: Mon, 16 Jun 2008 01:05:01 +0300 Subject: configure option to disable tests In-Reply-To: <877icq4m2j.fsf@mocca.josefsson.org> References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> <877icq4m2j.fsf@mocca.josefsson.org> Message-ID: <8e04b5820806151505o6a621e6btd2283ea2af94aacb@mail.gmail.com> On Sun, Jun 15, 2008 at 8:58 PM, Simon Josefsson wrote: > "Ciprian Dorin Craciun" writes: > >> Hello all! >> >> I'm writing this to make a small suggestion: it would be nice to >> have an option to disable the tests when building and installing. >> >> I'm asking this because I want to install libgcrypt to a >> non-standard location (ex. /packages/libgcrypt--1.4.1), and after >> installing it I want to symlink all includes and libs into >> /packages/.include /packages/.lib, but the tests fail by not finding >> the includes and libs (as they haven't been symlink-ed yet). > > Normally, self-tests doesn't require the program to be installed at all. > What errors do you get? > > /Simon > Attatched is the output of the installation process: -- lines starting with [xx] means command execution or failure; -- lines starting with [oo] means standard output, and [ee] means standard error; To see the error, please look at the end of the file. Thanks, Ciprian Craciun. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: log.txt URL: From ciprian.craciun at gmail.com Mon Jun 16 18:13:23 2008 From: ciprian.craciun at gmail.com (Ciprian Dorin Craciun) Date: Mon, 16 Jun 2008 19:13:23 +0300 Subject: configure option to disable tests In-Reply-To: <87k5gq1e4p.fsf@mocca.josefsson.org> References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> <877icq4m2j.fsf@mocca.josefsson.org> <8e04b5820806151505o6a621e6btd2283ea2af94aacb@mail.gmail.com> <87k5gq1e4p.fsf@mocca.josefsson.org> Message-ID: <8e04b5820806160913y142442cdr49ccd55e913ae7f@mail.gmail.com> On Mon, Jun 16, 2008 at 2:18 AM, Simon Josefsson wrote: > "Ciprian Dorin Craciun" writes: > >> [oo] Making install in tests >> [oo] make[1]: Entering directory `/tmp/vpm--1213567395239134476/output/tests' >> [oo] /bin/sh ../libtool --tag=CC --mode=link gcc -I/packages/libgpg-error--1.6/include -g -O2 -fvisibility=hidden -Wall -Wpointer-arith -L/packages/.lib -o ac-schemes ac-schemes.o ../src/libgcrypt.la >> [oo] gcc -I/packages/libgpg-error--1.6/include -g -O2 -fvisibility=hidden -Wall -Wpointer-arith -o .libs/ac-schemes ac-schemes.o -L/packages/.lib ../src/.libs/libgcrypt.so -Wl,--rpath -Wl,/packages/libgcrypt--1.4.1/lib >> [ee] ac-schemes.o: In function `scheme_get_opts': >> [ee] /tmp/vpm--1213567395239134476/sources/tests/ac-schemes.c:87: undefined reference to `gpg_err_code_from_errno' >> [ee] collect2: ld returned 1 exit status >> [ee] make[1]: *** [ac-schemes] Error 1 >> [ee] make: *** [install-recursive] Error 1 >> [oo] make[1]: Leaving directory `/tmp/vpm--1213567395239134476/output/tests' >> [XX] => failed; >> [XX] => failing; > > Could the -fvisibility=hidden be your problem? The self tests call > functions in libgpg-error, but it is only linked against libgcrypt. > Libgcrypt links to libgpg-error, so normally it would work. > > /Simon I don't know if -fvisibility=hidden is the problem... As I know the CFLAGS, LDFLAGS and LIBS are clean (CFLAGS contains only -I/packages/.include, and LDFLAGS -L/packages/.lib), so I don't think this is the problem. I must mention that I have libgpg-error installed, and that I am able to build and run other applications that use libgcrypt. Ciprian. From ciprian.craciun at gmail.com Mon Jun 16 18:16:46 2008 From: ciprian.craciun at gmail.com (Ciprian Dorin Craciun) Date: Mon, 16 Jun 2008 19:16:46 +0300 Subject: configure option to disable tests In-Reply-To: <87zlpl94hb.fsf@wheatstone.g10code.de> References: <8e04b5820806150346y61459dejd7ddeb955a10cce1@mail.gmail.com> <87zlpl94hb.fsf@wheatstone.g10code.de> Message-ID: <8e04b5820806160916x1d422118r337a565bee4aa54f@mail.gmail.com> On Mon, Jun 16, 2008 at 11:19 AM, Werner Koch wrote: > On Sun, 15 Jun 2008 12:46, ciprian.craciun at gmail.com said: > >> I'm asking this because I want to install libgcrypt to a >> non-standard location (ex. /packages/libgcrypt--1.4.1), and after >> installing it I want to symlink all includes and libs into >> /packages/.include /packages/.lib, but the tests fail by not finding >> the includes and libs (as they haven't been symlink-ed yet). > > It would be easier if you install the final packages (well the symlinks) > int /packages/{include,lib,bin}. This can be done by using: > > ./configure --prefix=/packages > make > make install prefix=/packages/libgcrypt--1.4.1 > > In your case you need to run configure with something like > > ./configure --bindir=/packages/.bin --libdir=/packages/.lib ..... > > and quite some more options. Check out ./configure --help. The make > invocations are still as show above. > > > Salam-Shalom, > > Werner > > > -- > Die Gedanken sind frei. Auschnahme regelt ein Bundeschgesetz. I know about the options --bindir and --libdir, but my setup was influenced by GoboLinux, where each package has it's own folder, and there is one common place for all the libs, bins, etc. That is why I install each package in a separate directory and then symlink them together. Ciprian Craciun. From szaki.ms at gmail.com Mon Jun 23 00:45:47 2008 From: szaki.ms at gmail.com (Szakats Istvan) Date: Mon, 23 Jun 2008 01:45:47 +0300 Subject: Fixed a few memory leaks Message-ID: <485ED61B.3070401@gmail.com> Hello I'm using version 1.4.0 of the gcrypt library. I don't know if this bug has already been fixed in CVS, but I found three memory leaks in the ac code. The attached patch fixes these issues. I don't know if it's the proper way to fix it, but it works, I have no more leaks and I haven't seen any new issues caused by the changes so far. Regards Steven -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: gcrypt_ac.patch URL: From wk at gnupg.org Mon Jun 23 18:00:13 2008 From: wk at gnupg.org (Werner Koch) Date: Mon, 23 Jun 2008 18:00:13 +0200 Subject: Fixed a few memory leaks In-Reply-To: <485ED61B.3070401@gmail.com> (Szakats Istvan's message of "Mon, 23 Jun 2008 01:45:47 +0300") References: <485ED61B.3070401@gmail.com> Message-ID: <87k5gg5egi.fsf@wheatstone.g10code.de> On Mon, 23 Jun 2008 00:45, szaki.ms at gmail.com said: > I'm using version 1.4.0 of the gcrypt library. I don't know if this > bug has already been fixed in CVS, but I found three memory leaks in > the ac code. The attached patch fixes these issues. I don't know if The ac code as a couple oftehse problems. Fixing them will be hard as there is no clear rule of memory ownership. My suggestion is not to use tha ac interface. Salam-Shalom, Werner -- Die Gedanken sind frei. Auschnahme regelt ein Bundeschgesetz. From simon at josefsson.org Wed Jun 25 12:44:11 2008 From: simon at josefsson.org (Simon Josefsson) Date: Wed, 25 Jun 2008 12:44:11 +0200 Subject: rijndael.c bus error in libgcrypt 1.4.1 on sparc solaris 10 In-Reply-To: <87hccehgjn.fsf@wheatstone.g10code.de> (Werner Koch's message of "Sat, 31 May 2008 13:14:04 +0200") References: <48341984.5070307@gnutls.org> <87iqx4yjrf.fsf@wheatstone.g10code.de> <87hccehgjn.fsf@wheatstone.g10code.de> Message-ID: <873an1okuc.fsf@mocca.josefsson.org> Werner Koch writes: > On Tue, 27 May 2008 07:45, preeti.shandilya at aricent.com said: > >> Attached is config.log : >> Following is the system information through prtconf > > Thanks. It seems that I would need to debug this. I have no such > machine available right now, so this is not easily possible. > > Let's see whether other folks have such a problem too and are able to > track down the problem. I got the same problem on Solaris 10 on SPARC with libgcrypt 1.4.1: my$ ./basic --debug Starting Cipher checks. checking BLOWFISH [4] checking DES [302] checking 3DES [2] checking CAST5 [3] checking AES [7] Bus Error my$ Program received signal SIGSEGV, Segmentation fault. 0xff328574 in do_decrypt (ctx=0xffbe0210, bx=0xffbe0200 "gC??Q\232???\232x?\t?\021?", ax=0xffbe0200 "gC??Q\232???\232x?\t?\021?") at rijndael.c:261 261 *((u32*)w) = *((u32*)U1[w[0]]) ^ *((u32*)U2[w[1]]) (gdb) bt #0 0xff328574 in do_decrypt (ctx=0xffbe0210, bx=0xffbe0200 "gC??Q\232???\232x?\t?\021?", ax=0xffbe0200 "gC??Q\232???\232x?\t?\021?") at rijndael.c:261 #1 0xff328b10 in rijndael_decrypt (context=0xffbe0210, b=0xffbe0200 "gC??Q\232???\232x?\t?\021?", a=0xffbe0200 "gC??Q\232???\232x?\t?\021?") at rijndael.c:679 #2 0xff328ce8 in rijndael_setkey (context=0x56000, key=0xffbe0550 "0123456789abcdef.,;/[]{}-=ABCDEF?9*", keylen=16) at rijndael.c:833 #3 0xff313dd4 in _gcry_cipher_ctl (h=0x55f98, cmd=1, buffer=0xffbe0550, buflen=16) at cipher.c:831 #4 0x000118e4 in check_one_cipher (algo=7, mode=1, flags=16) at basic.c:919 #5 0x0001280c in main (argc=1, argv=0xffbff174) at basic.c:1042 (gdb) I don't have time to debug further right now though. Libgcrypt 1.2.4 works fine. Some alignment-forcing code appear to have been removed between those two version. Another idea is that the padlock could changed the alignment of some variable. /Simon