[PATCH 3/3] Add support for GOST R 34.10-2001/-2012 signatures

[Dmitry Eremin-Solenikov]

Hello,

On Thu, Oct 3, 2013 at 8:14 AM, NIIBE Yutaka <gniibe at fsij.org> wrote:
> Patch looks great.  Here is my comment.
>
> I think that it's better to add ECC_DIALECT_GOST_R34_10 (or something
> like that) to ecc_dialects in src/mpi.h.  That's because it's a part
> of a curve definition, and domain parameters (only) make sense with
> this.

Hmm. Interesting suggestion. Maybe I failed to understand the purpose
of the domain field. From my understanding it is used only for key generation,
isn't it? Does it have any other usecases?

I thought about gost r 34.10 signatures as if they are 'just another format' of
ecdsa signatures. Thus I added a (flag gost) to data/signature generation.
IIUC, there is no any significant difference between ECDSA and GOST
curves/keys.

What do you think?

-- 
With best wishes
Dmitry