[RFC PATCH] Prepare random/win32.c fast poll for 64-bit Windows

Werner Koch wk at gnupg.org
Mon Apr 27 13:59:50 CEST 2015


On Sun, 26 Apr 2015 14:37, jussi.kivilinna at iki.fi said:

>> Introduce entropy gatherer changes related to 64-bit Windows platform as done
>> in cryptlib fast poll:
>>  - Change ADD macro to ADDPTR/ADDINT to handle pointer values. ADDPTR
>>    discards high 32-bits of 64-bit pointer values.
>>  - minimum/maximumWorkingSetSize changed to SIZE_T type to avoid stack
>>    corruption on 64-bit; only low 32-bits are used for entropy.
>>  - Use __rdtsc() intrinsic on 64-bit (as TSC is always available).
>> 
>> Signed-off-by: Jussi Kivilinna <jussi.kivilinna at iki.fi>
>> 
>> --
>> Would this be enough for 64-bit Windows support?
>> 
>> Slow poll differences cryptlib vs libgcrypt appear to be limited to sensor
>> data reading from third party programs and reading of PnP data.
>
> Any comments on this?

I can't say for sure whether this is sufficient.  But if this patch
tracks the changes from cryptlib it should be okay.  Cryptlib might have
introduced other changes since the last time I checked.

I assume you only looked for the 64 bit changes, right?


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gcrypt-devel mailing list