[PATCH 1/2] ecc-eddsa: free memory also when in error branch.
Ismo Puustinen
ismo.puustinen at intel.com
Wed Aug 5 14:27:43 CEST 2015
Fixing an issue found by static analysis.
Signed-off-by: Ismo Puustinen <ismo.puustinen at intel.com>
---
cipher/ecc-eddsa.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cipher/ecc-eddsa.c b/cipher/ecc-eddsa.c
index 4323d8e..268f0e8 100644
--- a/cipher/ecc-eddsa.c
+++ b/cipher/ecc-eddsa.c
@@ -607,8 +607,10 @@ _gcry_ecc_eddsa_sign (gcry_mpi_t input, ECC_secret_key *skey,
ctx = _gcry_mpi_ec_p_internal_new (skey->E.model, skey->E.dialect, 0,
skey->E.p, skey->E.a, skey->E.b);
b = (ctx->nbits+7)/8;
- if (b != 256/8)
- return GPG_ERR_INTERNAL; /* We only support 256 bit. */
+ if (b != 256/8) {
+ rc = GPG_ERR_INTERNAL; /* We only support 256 bit. */
+ goto leave;
+ }
rc = _gcry_ecc_eddsa_compute_h_d (&digest, skey->d, ctx);
if (rc)
--
2.4.3
More information about the Gcrypt-devel
mailing list