Patch to fix libgcrypt and KeepassX issue on FreeBSD

Jussi Kivilinna jussi.kivilinna at iki.fi
Tue Feb 16 09:09:39 CET 2016


Hello,

On 2016-02-16 01:45, Carlos J Puga Medina wrote:
> On Thu, 2015-11-26 at 20:25 +0200, Jussi Kivilinna wrote:
> 
> Hi Jussi,
> 
>> Hello,
>>
>> On 26.11.2015 11:37, Carlos J Puga Medina wrote:
>>> Hi people,
>>>
>>> The following patch fixes a current problem on FreeBSD. Please, can
>>> someone commit it for the next libgcrypt release?
>>>
>>
>> I managed to reproduce this on Ubuntu/clang and found bug in salsa20
>> selftest code. Does attached patch fix the issue for you?
> 
> It seems that those patches didn't solve the issue. At the moment, the
> cipher-Makefile.in patch fixes it.
> 
> See the following PR:
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207042
> 
> Please, can you take a look?

Seems as if "Ohhhh jeeee: Assertion `ctx->unused < 64' failed
(salsa20.c:400:salsa20_do_encrypt_stream)" is different issue than the
earlier crash. I'll look at it.

-Jussi

> 
> Best regards,
>>
>> -Jussi
>>
>>> --- cipher/Makefile.in.orig	2015-09-08 06:32:11 UTC
>>> +++ cipher/Makefile.in
>>> @@ -818,13 +818,19 @@ uninstall-am:
>>>  	tags tags-am uninstall uninstall-am
>>>  
>>>  
>>> -# We need to lower the optimization for this module.
>>> +# We need to lower the optimization for these modules.
>>>  tiger.o: $(srcdir)/tiger.c
>>>  	`echo $(COMPILE) -c $(srcdir)/tiger.c | $(o_flag_munging)
>>> `
>>>  
>>>  tiger.lo: $(srcdir)/tiger.c
>>>  	`echo $(LTCOMPILE) -c $(srcdir)/tiger.c |
>>> $(o_flag_munging) `
>>>  
>>> +salsa20.o: $(srcdir)/salsa20.c
>>> +	`echo $(COMPILE) -c $(srcdir)/salsa20.c |
>>> $(o_flag_munging) `
>>> +
>>> +salsa20.lo: $(srcdir)/salsa20.c
>>> +	`echo $(LTCOMPILE) -c $(srcdir)/salsa20.c |
>>> $(o_flag_munging)
>>> `
>>> +
>>>  # Tell versions [3.59,3.63) of GNU make to not export all
>>> variables.
>>>  # Otherwise a system limit (for SysV at least) may be exceeded.
>>>  .NOEXPORT:
>>>
>>> See bug 204323 for further details:
>>>
>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204323
>>>
>>> Kind regards,
>>>
>>>
>>>
>>> _______________________________________________
>>> Gcrypt-devel mailing list
>>> Gcrypt-devel at gnupg.org
>>> http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
>>>
>>



More information about the Gcrypt-devel mailing list