[PATCH] sm3: implement SM3 hash algorithm

Jia Zhang qianyue.zj at alibaba-inc.com
Tue Oct 17 04:24:22 CEST 2017


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



于 2017/10/17 上午9:03, NIIBE Yutaka 写道:
> "张佳(乾越)" <qianyue.zj at alibaba-inc.com> wrote:
>> Hi Werner,
> 
> Sorry, I'm not Werner, but another (old 老头儿) developer of
> libgcrypt.

Thanks for your great comments!

> 
>> This is the review request for SM3 hash algorithm. Plz see the
>> commit header and patch for more details.
> 
> To track this, I created a ticket at: https://dev.gnupg.org/T3454
> 
> 
> Could you please send the patch to gcrypt-devel?  Or, you can
> upload your patch to:
> 
> https://dev.gnupg.org/differential/

I just created it. See https://dev.gnupg.org/D449.

> 
>> SM3 hash algorithm is already accepted and supported by TPM 2.0
>> spec. So it is necessary to implement this algorithm in a famous
>> open source software for checking the digest value computed by
>> TPM.
> 
> Out of curiosity, is it mandated by the goverment?  If so, how
> about SM2?
> 
> When I read FIDO U2F document in this April, I learned about
> optional SM2 and SM3.

To be honest, I'm not quite sure it. But at least we are seeing it is
also for civil use. I don't want to see the thing gets complicated,
cause my original intention is quite simple. I see my TPM supports SM3
but there is no sm3sum program in coreutils to verify the hash value.
Just contribute SM3 hash function to the famous open source community
and make it easy to use.

I'm not familiar with SM2, but I confirm I will submit it if SM3 is
approved.

> 
>> Plz refer to this PR (https://github.com/gpg/libgcrypt/pull/2)
>> for code review.
> 
> We don't have a practice to use GitHub, which might require
> non-free JavaScript.
> 
> Please read libgcrypt/doc/HACKING, the "How to contribute"
> section, especially the "License policy" subsection.

I'm doing this. Copyright assignment is fine to me.

Jia

> 
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoCC9pk5gdr326JdrPMRi5TbAeCkFAlnladYACgkQPMRi5TbA
eCmnnQ//fmPvCtzNOSaUSX3i87rvWz9fbk6OhvFNz4xKKryHbe2wsEXAiuhTtFxo
KQrRgrKBC1cKq5VN6MgCE59i5jYn2sCBOST/KeQr8esVwR1QyZBs8hlVi0lGn9Gr
mC8C/GSKcqLVNuoHjfYk6iFkEx3Zh7oA5xEfC1Yq1bbAmnlIbkEQWaUJA85ZeADJ
4BFsb1bUvZzc0YhBKtmV0FdxN5pOpzZaww81mXhNdxaTH8yAc1nJ6rpo4VQgFs5d
0xkmB5qeFRtToA7HKK8zUsyT1FlOJ3KYnL3bHoGIN5rJafKUcS17HziHS2onb42c
RUgzdbvtRThBC/yE6sc95qGXrmM4dRJn5AdNFpXCUmHTK29V7gmp5t3DjJgtoSV+
Es/nPps2WTI+2Zp+i5chwPGGrljq73LcuCPE9sijEVfqmTV1rgsFmqy13Qk0vdQX
MrkRGvG6M6dRAi4MJx6HFIgtcONlgByaFBvdamfpRHso4rdFzKA4Cy/S6+fHEngl
uitJmxnqHQYCXG0dDzUJfvrCtkaxKPWDgd+KmdDN9lVtMlEkeVVA6Zbay2tjB6f8
FjHataRSyj+zy+cp9vLAz8jIzI+EN6/yvDr6JOz/w2fCI1pLwQSAtsepoLuawAMz
ogHPXvC0jnh8483eHIjcSva0aRAKAH/b9P1FVChd4Sx/hQ3VzpA=
=xk8n
-----END PGP SIGNATURE-----



More information about the Gcrypt-devel mailing list