[PATCH 4/5] aarch64: camellia: Only use the lower 32 bit of an int parameter

Jussi Kivilinna jussi.kivilinna at iki.fi
Thu Mar 22 20:19:48 CET 2018


On 22.03.2018 10:56, Martin Storsjö wrote:
> The keybits parameter is declared as int, and in those cases, the
> upper half of a register is undefined, not guaranteed to be zero.
> Signed-off-by: Martin Storsjö <martin at martin.st>
> ---
> I didn't check other files and functions for the same issue, I
> just happened to notice this one while looking closer at the
> camellia source file.
> From previous experience, clang can be pretty aggressive with
> passing in undefined data in the upper half of registers, where
> it isn't supposed to make any difference.

I'll do review on the other aarch64 implementations for this.


More information about the Gcrypt-devel mailing list