[git] GCRYPT - branch, master, updated. libgcrypt-1.8.1-90-ge2da4e8

by Werner Koch cvs at cvs.gnupg.org
Tue Oct 23 22:59:45 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU crypto library".

The branch, master has been updated
       via  e2da4e8dee4b371804f3b2659b53431fb6380d93 (commit)
       via  9f2c7ec4d8b07e82663ad084c90c016d3c3b80c2 (commit)
       via  282f238f7788267768e823c0976aff15aeaff103 (commit)
      from  0f2c6ce2c9504c6df435463243edaa669e57b109 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e2da4e8dee4b371804f3b2659b53431fb6380d93
Author: Werner Koch <wk at gnupg.org>
Date:   Tue Oct 23 22:58:09 2018 +0200

    ecc: Fix potential unintended freeing of an internal param.
    * cipher/ecc-curves.c (_gcry_ecc_get_mpi): Fix c+p error
    GnuPG-bug-id: 4208
    Signed-off-by: Werner Koch <wk at gnupg.org>

diff --git a/cipher/ecc-curves.c b/cipher/ecc-curves.c
index 86d0b4e..75d7161 100644
--- a/cipher/ecc-curves.c
+++ b/cipher/ecc-curves.c
@@ -1206,7 +1206,7 @@ _gcry_ecc_get_mpi (const char *name, mpi_ec_t ec, int copy)
   if (!strcmp (name, "q.x") && ec->Q && ec->Q->x)
     return mpi_is_const (ec->Q->x) && !copy? ec->Q->x : mpi_copy (ec->Q->x);
   if (!strcmp (name, "q.y") && ec->Q && ec->Q->y)
-    return mpi_is_const (ec->G->y) && !copy? ec->Q->y : mpi_copy (ec->Q->y);
+    return mpi_is_const (ec->Q->y) && !copy? ec->Q->y : mpi_copy (ec->Q->y);
   /* If the base point has been requested, return it in standard
      encoding.  */

commit 9f2c7ec4d8b07e82663ad084c90c016d3c3b80c2
Author: Werner Koch <wk at gnupg.org>
Date:   Tue Oct 23 22:51:40 2018 +0200

    sexp: Fix uninitialized use of a var in the error case.
    * src/sexp.c (_gcry_sexp_vextract_param): Initialize L1.
    GnuPG-bug-id: 4212
    Signed-off-by: Werner Koch <wk at gnupg.org>

diff --git a/src/gcrypt.h.in b/src/gcrypt.h.in
index d2dfe80..36bbf20 100644
--- a/src/gcrypt.h.in
+++ b/src/gcrypt.h.in
@@ -1318,7 +1318,7 @@ gpg_error_t gcry_md_extract (gcry_md_hd_t hd, int algo, void *buffer,
                              size_t length);
 /* Convenience function to calculate the hash from the data in BUFFER
-   of size LENGTH using the algorithm ALGO avoiding the creating of a
+   of size LENGTH using the algorithm ALGO avoiding the creation of a
    hash object.  The hash is returned in the caller provided buffer
    DIGEST which must be large enough to hold the digest of the given
    algorithm. */
diff --git a/src/sexp.c b/src/sexp.c
index 9d89268..f2a164c 100644
--- a/src/sexp.c
+++ b/src/sexp.c
@@ -2232,7 +2232,7 @@ _gcry_sexp_vextract_param (gcry_sexp_t sexp, const char *path,
   gcry_mpi_t *array[20];
   char arrayisdesc[20];
   int idx;
-  gcry_sexp_t l1;
+  gcry_sexp_t l1 = NULL;
   int mode = '+'; /* Default to GCRYMPI_FMT_USG.  */
   gcry_sexp_t freethis = NULL;

commit 282f238f7788267768e823c0976aff15aeaff103
Author: Werner Koch <wk at gnupg.org>
Date:   Thu Jun 14 10:39:53 2018 +0200

    doc: Fix example for gcry_sexp_extract_param

diff --git a/doc/gcrypt.texi b/doc/gcrypt.texi
index 4cae489..4f4f973 100644
--- a/doc/gcrypt.texi
+++ b/doc/gcrypt.texi
@@ -4472,14 +4472,15 @@ an @code{gcry_mpi_t} variable is expected that must be set to
 is expected.  For example
-  _gcry_sexp_extract_param (key, NULL, "n/x+e d-'foo'",
-                            &mpi_n, &mpi_x, &mpi_e, &mpi_foo, NULL)
+  gcry_sexp_extract_param (key, NULL, "n/x+e d-'foo'",
+                           &mpi_n, &mpi_x, &mpi_e, &mpi_d, &mpi_foo, NULL)
 @end example
 stores the parameter 'n' from @var{key} as an unsigned MPI into
 @var{mpi_n}, the parameter 'x' as an opaque MPI into @var{mpi_x}, the
-parameter 'e' again as an unsigned MPI into @var{mpi_e}, and the
-parameter 'foo' as a signed MPI.
+parameters 'e' and 'd' again as an unsigned MPI into @var{mpi_e} and
+ at var{mpi_d} and finally the parameter 'foo' as a signed MPI into
+ at var{mpi_foo}.
 @var{path} is an optional string used to locate a token.  The
 exclamation mark separated tokens are used via


Summary of changes:
 cipher/ecc-curves.c | 2 +-
 doc/gcrypt.texi     | 9 +++++----
 src/gcrypt.h.in     | 2 +-
 src/sexp.c          | 2 +-
 4 files changed, 8 insertions(+), 7 deletions(-)

The GNU crypto library

Gnupg-commits mailing list
Gnupg-commits at gnupg.org

More information about the Gcrypt-devel mailing list