[PATCH 1/4] ecc: rename 512-bit GOST curves

[Dmitry Eremin-Solenikov]

вт, 12 нояб. 2019 г. в 18:20, Werner Koch <wk at gnupg.org>:
>
> On Tue, 12 Nov 2019 10:58, Dmitry Eremin-Solenikov said:
>
> > * cipher/ecc-curves.c (domain_parms): rename GOST 2012 curves to contain
> >   curve bit size
> >   (curve_aliases): rename curves and provide backwards-compatible
> >   aliases.
>
> I can't immediately see that there are new aliases.

GOST2012-tc26-A is a current name, now provided in alias.
GOST2012-512-tc26-A is a new curve name.

>
> > -    { "GOST2012-tc26-A", "1.2.643.7.1.2.1.2.1" },
> > -    { "GOST2012-tc26-B", "1.2.643.7.1.2.1.2.2" },
>
> These have been removed but we need to keep them - at least as an alias.
> Actually even turning the curves into an alias would be an ABI change;
> however we can accept that.

Hmm. I have added aliases both for OIDs and for old names. Could you
please tell what did I miss?

>
> > -      "GOST2012-test", 511, 0,
> > +      "GOST2012-512-test", 511, 0,
>
> Ditto.

Ah, I missed this one. I'll add GOST2012-test alias to point to
GOST2012-512-test.

>
> Can you please check again and if possible I would also appreciate a
> single patch for the new curve names.

Which patches would you like to be squashed? Or should I just update this patch?

-- 
With best wishes
Dmitry