[PATCH] Fix three errors for ec algorithm

NIIBE Yutaka gniibe at fsij.org
Thu Jan 9 00:24:52 CET 2020


Jussi Kivilinna via Gcrypt-devel wrote:
> Thanks for your contributions. I'll leave some comments on the patches
> in few days but it would be better if someone more familiar with
> MPI/EC side of gcrypt checks the patches too.

Acked by me for:
   [PATCH 1/3] Update .gitignore
   [PATCH v2] mpi: Fix error that point not uninitialized
   [PATCH 3/3] ecc: Wrong flag and elements_enc fix.

To Tianjia Zhang: Thanks for your good catch.  I just realized that you
also sent me other patches directly to me for review.  I'll do that

My excuse for 3/3 is that: the feature (flags param) is basically for
classic ECC where (some) people want to define their own domain
parameters, and it has been not used with modern ECC (which may have
eddsa or djb-tweak flag).  For the _gcry_pubkey_spec_ecc fix, I should
have fixed the "sw" -> "se" when I touched other parameters.

More information about the Gcrypt-devel mailing list