[PATCH v2 2/2] Add SM4 ARMv8/AArch64 assembly implementation

[Tianjia Zhang]

Hi Jussi,

On 2/23/22 2:22 AM, Jussi Kivilinna wrote:
> On 22.2.2022 14.18, Tianjia Zhang wrote:
>> * cipher/Makefile.am: Add 'sm4-aarch64.S'.

>> +
>> +/* Constants */
>> +
>> +.text
>> +.align 16
> 
> Alignment to 65536 bytes seems excessive. Did you mean to use
> 16-byte aligment here (".align 4" or ".balign 16")?

Thanks for pointing it out, you're right, I meant for 16 byte alignment,
I'll fix it in v3 patch.

> 
> Otherwise patches look good. On Cortex-A53, ~36% performance
> improvement seen for CFB/CBC/CTR/OCB.


Great job, thanks for the test data.

Kind regards,
Tianjia