[PATCH 2/3] mpih-const-time: avoid branches in _gcry_mpih_cmp_ui

NIIBE Yutaka gniibe at fsij.org
Tue Feb 11 02:33:52 CET 2025


Hello, Jussi,

Jussi Kivilinna <jussi.kivilinna at iki.fi> wrote:
> * mpi/mpih-const-time.c (_gcry_mpih_cmp_ui): Avoid conditional
> branches for return value selection.

Thank you for your work.  This is good for constant-time property.

Another one:

    [PATCH 3/3] mpi/longlong: prevent optimization of carry instructions to branches (inbox lists lists/gcrypt-devel)

is also good.  Please apply and push your changes of [PATCH 2/3] and [PATCH 3/3].


For the fix of:

    [PATCH 1/3] t-fips-service-ind: fix broken fail print (inbox lists lists/gcrypt-devel)

This fix is also included by Lucas Mulling's post of 2025-01-28:

     Message-ID: <CAK8Nc5N_Zz2cuCNrnspZO4JbZqooF=44TpGO1DwJ7fNgJKxdiA at mail.gmail.com>

I think that it's better applying his one (when Werner agrees).
-- 



More information about the Gcrypt-devel mailing list