[svn] GnuPG - r4098 - branches/GNUPG-1-9-BRANCH/agent

[svn author mo]

Author: mo
Date: 2006-04-09 13:31:37 +0200 (Sun, 09 Apr 2006)
New Revision: 4098

Modified:
   branches/GNUPG-1-9-BRANCH/agent/ChangeLog
   branches/GNUPG-1-9-BRANCH/agent/command-ssh.c
Log:
2006-04-09  Moritz Schulte  <moritz at g10code.com>

	* command-ssh.c (ssh_request_process): Removed FIXME mentioning a
	possible DoS attack.


Modified: branches/GNUPG-1-9-BRANCH/agent/ChangeLog
===================================================================
--- branches/GNUPG-1-9-BRANCH/agent/ChangeLog	2006-04-09 03:34:09 UTC (rev 4097)
+++ branches/GNUPG-1-9-BRANCH/agent/ChangeLog	2006-04-09 11:31:37 UTC (rev 4098)
@@ -1,3 +1,8 @@
+2006-04-09  Moritz Schulte  <moritz at g10code.com>
+
+	* command-ssh.c (ssh_request_process): Removed FIXME mentioning a
+	possible DoS attack.
+
 2006-04-01  Moritz Schulte  <moritz at g10code.com>
 
 	* command-ssh.c (ssh_identity_register): Make KEY_GRIP_RAW be 20

Modified: branches/GNUPG-1-9-BRANCH/agent/command-ssh.c
===================================================================
--- branches/GNUPG-1-9-BRANCH/agent/command-ssh.c	2006-04-09 03:34:09 UTC (rev 4097)
+++ branches/GNUPG-1-9-BRANCH/agent/command-ssh.c	2006-04-09 11:31:37 UTC (rev 4098)
@@ -1,5 +1,5 @@
 /* command-ssh.c - gpg-agent's ssh-agent emulation layer
- * Copyright (C) 2004, 2005 Free Software Foundation, Inc.
+ * Copyright (C) 2004, 2005, 2006 Free Software Foundation, Inc.
  *
  * This file is part of GnuPG.
  *
@@ -2677,10 +2677,13 @@
      secret key material.  The response does not have to be stored in
      secure memory, since we never give out secret keys. 
 
-     FIXME: This is a pretty good DoS.  We only have a limited amount
-     of secure memory, we can't throw in everything we get from a
-     client -wk */
-      
+     Note: we only have little secure memory, but there is NO
+     possibility of DoS here; only trusted clients are allowed to
+     connect to the agent.  What could happen is that the agent
+     returns out-of-secure-memory errors on requests in case the
+     agent's owner floods his own agent with many large messages.
+     -moritz */
+
   /* Retrieve request.  */
   err = stream_read_string (stream_sock, 1, &request_data, &request_data_size);
   if (err)