[svn] GnuPG - r4445 - branches/STABLE-BRANCH-1-4/g10

[svn author dshaw]

Author: dshaw
Date: 2007-03-06 07:39:38 +0100 (Tue, 06 Mar 2007)
New Revision: 4445

Modified:
   branches/STABLE-BRANCH-1-4/g10/ChangeLog
   branches/STABLE-BRANCH-1-4/g10/getkey.c
   branches/STABLE-BRANCH-1-4/g10/keyedit.c
Log:
* keyedit.c (keyedit_menu): If we modify the keyblock (via
fix_keyblock() or collapse_uids()) make sure we reprocess the keyblock
so the flags are correct.  Noted by Robin H. Johnson.

* getkey.c (fixup_uidnode): Properly clear flags that don't apply to
us (revoked, expired) so that we can reprocess a uid.


Modified: branches/STABLE-BRANCH-1-4/g10/ChangeLog
===================================================================
--- branches/STABLE-BRANCH-1-4/g10/ChangeLog	2007-03-05 14:56:31 UTC (rev 4444)
+++ branches/STABLE-BRANCH-1-4/g10/ChangeLog	2007-03-06 06:39:38 UTC (rev 4445)
@@ -1,3 +1,12 @@
+2007-03-06  David Shaw  <dshaw at jabberwocky.com>
+
+	* keyedit.c (keyedit_menu): If we modify the keyblock (via
+	fix_keyblock() or collapse_uids()) make sure we reprocess the
+	keyblock so the flags are correct.  Noted by Robin H. Johnson.
+
+	* getkey.c (fixup_uidnode): Properly clear flags that don't apply
+	to us (revoked, expired) so that we can reprocess a uid.
+
 2007-03-01  David Shaw  <dshaw at jabberwocky.com>
 
 	* options.h, gpg.c (main), mainproc.c (check_sig_and_print): Allow

Modified: branches/STABLE-BRANCH-1-4/g10/getkey.c
===================================================================
--- branches/STABLE-BRANCH-1-4/g10/getkey.c	2007-03-05 14:56:31 UTC (rev 4444)
+++ branches/STABLE-BRANCH-1-4/g10/getkey.c	2007-03-06 06:39:38 UTC (rev 4445)
@@ -1485,10 +1485,13 @@
 
     sig->flags.chosen_selfsig = 1; /* we chose this one */
     uid->created = 0; /* not created == invalid */
-    if ( IS_UID_REV ( sig ) ) {
+    if ( IS_UID_REV ( sig ) )
+      {
         uid->is_revoked = 1;
         return; /* has been revoked */
-    }
+      }
+    else
+      uid->is_revoked=0;
 
     uid->expiredate = sig->expiredate;
 
@@ -1497,6 +1500,8 @@
 	uid->is_expired = 1;
 	return; /* has expired */
       }
+    else
+      uid->is_expired=0;
 
     uid->created = sig->timestamp; /* this one is okay */
     uid->selfsigversion = sig->version;

Modified: branches/STABLE-BRANCH-1-4/g10/keyedit.c
===================================================================
--- branches/STABLE-BRANCH-1-4/g10/keyedit.c	2007-03-05 14:56:31 UTC (rev 4444)
+++ branches/STABLE-BRANCH-1-4/g10/keyedit.c	2007-03-06 06:39:38 UTC (rev 4445)
@@ -1541,6 +1541,10 @@
     if( collapse_uids( &keyblock ) )
 	modified++;
     reorder_keyblock(keyblock);
+    /* We modified the keyblock, so let's make sure the flags are
+       right. */
+    if(modified)
+      merge_keys_and_selfsig( keyblock );
 
     if(seckey_check)
       {/* see whether we have a matching secret key */