[svn] GnuPG - r4887 - in trunk: . tools

[svn author wk]

Author: wk
Date: 2008-12-08 18:11:26 +0100 (Mon, 08 Dec 2008)
New Revision: 4887

Modified:
   trunk/THANKS
   trunk/tools/ChangeLog
   trunk/tools/gpgkey2ssh.c
Log:
Fix bug 901.


Modified: trunk/tools/ChangeLog
===================================================================
--- trunk/tools/ChangeLog	2008-12-08 11:50:05 UTC (rev 4886)
+++ trunk/tools/ChangeLog	2008-12-08 17:11:26 UTC (rev 4887)
@@ -1,3 +1,9 @@
+2008-12-08  Werner Koch  <wk at g10code.com>
+
+	* gpgkey2ssh.c (main): Change order of output for RSA. Change name
+	of DSA identifier.  Reported by Daniel Kahn Gillmor.  This is
+	bug#901.
+
 2008-12-05  Werner Koch  <wk at g10code.com>
 
 	* gpg-connect-agent.c (opts): Use ARGPARSE_ macros.

Modified: trunk/THANKS
===================================================================
--- trunk/THANKS	2008-12-08 11:50:05 UTC (rev 4886)
+++ trunk/THANKS	2008-12-08 17:11:26 UTC (rev 4887)
@@ -48,6 +48,7 @@
 Daiki Ueno                 ueno at unixuser.org
 Dan Winship                danw at helixcode.com
 Daniel Eisenbud 	   eisenbud at cs.swarthmore.edu
+Daniel Kahn Gillmor        dkg at fifthhorseman dot net
 Daniel Koening		   dan at chaosdorf.de
 Daniel Leidert             daniel leidert at wgdd.de
 Daniel Resare		   daniel at resare.com

Modified: trunk/tools/gpgkey2ssh.c
===================================================================
--- trunk/tools/gpgkey2ssh.c	2008-12-08 11:50:05 UTC (rev 4886)
+++ trunk/tools/gpgkey2ssh.c	2008-12-08 17:11:26 UTC (rev 4887)
@@ -1,4 +1,4 @@
-/* gpgkey2ssh.c - Converter ...
+/* gpgkey2ssh.c - Converter  (Debug helper)
  *	Copyright (C) 2005 Free Software Foundation, Inc.
  *
  * This file is part of GnuPG.
@@ -17,6 +17,15 @@
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+/* 
+   FIXME:  This tool needs some cleanup:
+
+   - Do not use assert() for error output.
+   - Add proper option parsing and standard options.
+   - retrieve_key_material needs to take the ordinal at field 1 in account.
+   0 Write a man page.
+*/
+
 #include <config.h>
 
 #include <gcrypt.h>
@@ -272,11 +281,11 @@
     {
       identifier = "ssh-rsa";
       ret = key_to_blob (&blob, &blob_n, identifier,
-			 &pkdbuf[0], &pkdbuf[1], NULL);
+			 &pkdbuf[1], &pkdbuf[0], NULL);
     }
   else if (algorithm_id == 17)
     {
-      identifier = "ssh-dsa";
+      identifier = "ssh-dss";
       ret = key_to_blob (&blob, &blob_n, identifier,
 			 &pkdbuf[0], &pkdbuf[1], &pkdbuf[2], &pkdbuf[3], NULL);
     }