[svn] gcry - r1405 - branches/LIBGCRYPT-1-4-BRANCH/cipher

[svn author wk]

Author: wk
Date: 2009-08-21 11:34:39 +0200 (Fri, 21 Aug 2009)
New Revision: 1405

Modified:
   branches/LIBGCRYPT-1-4-BRANCH/cipher/ChangeLog
   branches/LIBGCRYPT-1-4-BRANCH/cipher/dsa.c
Log:
Fix memleak in DSA key generation


Modified: branches/LIBGCRYPT-1-4-BRANCH/cipher/ChangeLog
===================================================================
--- branches/LIBGCRYPT-1-4-BRANCH/cipher/ChangeLog	2009-08-21 09:34:16 UTC (rev 1404)
+++ branches/LIBGCRYPT-1-4-BRANCH/cipher/ChangeLog	2009-08-21 09:34:39 UTC (rev 1405)
@@ -1,3 +1,8 @@
+2009-08-21  Werner Koch  <wk at g10code.com>
+
+	* dsa.c (dsa_generate_ext): Release retfactors array before
+	setting it to NULL.  Reported by Daiko Ueno.
+
 2009-01-22  Werner Koch  <wk at g10code.com>
 
 	* ecc.c (compute_keygrip): Remove superfluous const.

Modified: branches/LIBGCRYPT-1-4-BRANCH/cipher/dsa.c
===================================================================
--- branches/LIBGCRYPT-1-4-BRANCH/cipher/dsa.c	2009-08-21 09:34:16 UTC (rev 1404)
+++ branches/LIBGCRYPT-1-4-BRANCH/cipher/dsa.c	2009-08-21 09:34:39 UTC (rev 1405)
@@ -907,6 +907,7 @@
               gcry_mpi_release ((*retfactors)[i]);
               (*retfactors)[i] = NULL;
             }
+          gcry_free (*retfactors);
           *retfactors = NULL;
           if (ec)
             {