[svn] GnuPG - r5321 - in trunk: common g10

[svn author wk]

Author: wk
Date: 2010-04-26 13:53:14 +0200 (Mon, 26 Apr 2010)
New Revision: 5321

Modified:
   trunk/common/ChangeLog
   trunk/common/init.c
   trunk/common/utf8conv.c
   trunk/g10/ChangeLog
   trunk/g10/decrypt.c
   trunk/g10/keygen.c
   trunk/g10/seckey-cert.c
Log:
Fix preference setting in new keys


Modified: trunk/common/ChangeLog
===================================================================
--- trunk/common/ChangeLog	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/common/ChangeLog	2010-04-26 11:53:14 UTC (rev 5321)
@@ -1,3 +1,10 @@
+2010-04-26  Werner Koch  <wk at g10code.com>
+
+	* utf8conv.c (load_libiconv) [W32CE]: No libiconv warning
+
+	* init.c (init_common_subsystems) [W32CE]: Register the sleep
+	function before es_init.
+
 2010-04-20  Werner Koch  <wk at g10code.com>
 
 	* estream.c (es_deinit): New.

Modified: trunk/g10/ChangeLog
===================================================================
--- trunk/g10/ChangeLog	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/g10/ChangeLog	2010-04-26 11:53:14 UTC (rev 5321)
@@ -1,3 +1,9 @@
+2010-04-26  Werner Koch  <wk at g10code.com>
+
+	* keygen.c (keygen_set_std_prefs): Explicitly include Z0 in the
+	default preferences if no compression algorithms are available.
+	Remove a possible trailing space in the dummy_string.
+
 2010-04-23  Werner Koch  <wk at g10code.com>
 
 	* pubkey-enc.c (get_it): Use the agent for decryption.

Modified: trunk/common/init.c
===================================================================
--- trunk/common/init.c	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/common/init.c	2010-04-26 11:53:14 UTC (rev 5321)
@@ -73,13 +73,21 @@
 # ifdef HAVE_PTH
   pth_init ();
 # else
- {
-   WSADATA wsadat;
-
-   WSAStartup (0x202, &wsadat);
- }
+  {
+    WSADATA wsadat;
+    
+    WSAStartup (0x202, &wsadat);
+  }
 # endif /*!HAVE_PTH*/
 #endif
+  
+#ifdef HAVE_W32CE_SYSTEM
+  /* Register the sleep exit function before the estream init so that
+     the sleep will be called after the estream registered atexit
+     function which flushes the left open estream streams and in
+     particular es_stdout.  */
+  atexit (sleep_on_exit);
+#endif
 
   /* Initialize the Estream library. */
   es_init ();
@@ -87,7 +95,6 @@
   /* Special hack for Windows CE: We extract some options from arg
      to setup the standard handles.  */
 #ifdef HAVE_W32CE_SYSTEM
-  atexit (sleep_on_exit);
   parse_std_file_handles (argcp, argvp);
 #else
   (void)argcp;

Modified: trunk/common/utf8conv.c
===================================================================
--- trunk/common/utf8conv.c	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/common/utf8conv.c	2010-04-26 11:53:14 UTC (rev 5321)
@@ -62,6 +62,10 @@
 static int 
 load_libiconv (void)
 {
+#ifdef HAVE_W32CE_SYSTEM
+  return -1; /* FIXME No libiconv yet - Need to investigate whether it
+                is at all required.  */
+#else
   static int done;
   
   if (!done)
@@ -94,6 +98,7 @@
         }
     }
   return iconv_open? 0: -1;
+#endif
 }    
 #endif /*HAVE_W32_SYSTEM*/
 

Modified: trunk/g10/decrypt.c
===================================================================
--- trunk/g10/decrypt.c	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/g10/decrypt.c	2010-04-26 11:53:14 UTC (rev 5321)
@@ -132,7 +132,7 @@
     }
 
 #ifdef HAVE_W32CE_SYSTEM
-#warning Ned to fix this
+#warning Need to fix this
   opt.outfp = NULL;
 #else
   opt.outfp = fdopen (dup (output_fd), "wb");

Modified: trunk/g10/keygen.c
===================================================================
--- trunk/g10/keygen.c	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/g10/keygen.c	2010-04-26 11:53:14 UTC (rev 5321)
@@ -315,6 +315,7 @@
 	  string=opt.def_preference_list;
 	else
 	  {
+            int any_compress = 0;
 	    dummy_string[0]='\0';
 
             /* The rationale why we use the order AES256,192,128 is
@@ -375,14 +376,32 @@
 	      strcat (dummy_string, "H11 ");
 
 	    if(!check_compress_algo(COMPRESS_ALGO_ZLIB))
-              strcat(dummy_string,"Z2 ");
+              {
+                strcat(dummy_string,"Z2 ");
+                any_compress = 1;
+              }
 
 	    if(!check_compress_algo(COMPRESS_ALGO_BZIP2))
-	      strcat(dummy_string,"Z3 ");
+              {
+                strcat(dummy_string,"Z3 ");
+                any_compress = 1;
+              }
 
 	    if(!check_compress_algo(COMPRESS_ALGO_ZIP))
-              strcat(dummy_string,"Z1");
+              {
+                strcat(dummy_string,"Z1 ");
+                any_compress = 1;
+              }
+            
+            /* In case we have no compress algo at all, declare that
+               we prefer no compresssion.  */
+            if (!any_compress)
+              strcat(dummy_string,"Z0 ");
 
+            /* Remove the trailing space.  */
+            if (*dummy_string && dummy_string[strlen (dummy_string)-1] == ' ')
+              dummy_string[strlen (dummy_string)-1] = 0;
+
 	    string=dummy_string;
 	  }
       }

Modified: trunk/g10/seckey-cert.c
===================================================================
--- trunk/g10/seckey-cert.c	2010-04-23 11:36:59 UTC (rev 5320)
+++ trunk/g10/seckey-cert.c	2010-04-26 11:53:14 UTC (rev 5321)
@@ -35,6 +35,7 @@
 #include "status.h"
 #include "pkglue.h"
 
+#if 0 /* Not anymore used - kept for reference.  */
 static int
 do_check( PKT_secret_key *sk, const char *tryagain_text, int mode,
           int *canceled )
@@ -256,9 +257,9 @@
 
     return 0;
 }
+#endif /*0*/
 
 
-
 /****************
  * check whether the secret key is protected.
  * Returns: 0 not protected, -1 on error or the protection algorithm