[git] GnuPG - branch, master, updated. gnupg-2.1.0-71-g1938150

[by Werner Koch]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU Privacy Guard".

The branch, master has been updated
       via  193815030d20716d9a97850013ac3cc8749022c9 (commit)
      from  1d8ebe4d54eef37da65e7bd5d7386bc04f344447 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 193815030d20716d9a97850013ac3cc8749022c9
Author: Werner Koch <wk at gnupg.org>
Date:   Fri Dec 12 10:41:25 2014 +0100

    gpg: Fix possible read of unallocated memory
    
    * g10/parse-packet.c (can_handle_critical): Check content length
    before calling can_handle_critical_notation.
    --
    
    The problem was found by Jan Bee and gniibe proposed the used fix.
    Thanks.
    
    This bug can't be exploited: Only if the announced length of the
    notation is 21 or 32 a memcmp against fixed strings using that length
    would be done.  The compared data is followed by the actual signature
    and thus it is highly likely that not even read of unallocated memory
    will happen.  Nevertheless such a bug needs to be fixed.
    
    Signed-off-by: Werner Koch <wk at gnupg.org>

diff --git a/g10/parse-packet.c b/g10/parse-packet.c
index 58cb1c4..1de7307 100644
--- a/g10/parse-packet.c
+++ b/g10/parse-packet.c
@@ -1387,10 +1387,12 @@ can_handle_critical (const byte * buffer, size_t n, int type)
     {
     case SIGSUBPKT_NOTATION:
       if (n >= 8)
-	return can_handle_critical_notation (buffer + 8,
-					     (buffer[4] << 8) | buffer[5]);
-      else
-	return 0;
+	{
+	  size_t notation_len = ((buffer[4] << 8) | buffer[5]);
+	  if (n - 8 >= notation_len)
+	    return can_handle_critical_notation (buffer + 8, notation_len);
+	}
+      return 0;
     case SIGSUBPKT_SIGNATURE:
     case SIGSUBPKT_SIG_CREATED:
     case SIGSUBPKT_SIG_EXPIRE:

-----------------------------------------------------------------------

Summary of changes:
 g10/parse-packet.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
The GNU Privacy Guard
http://git.gnupg.org