[git] Pinentry - branch, master, updated. pinentry-0.9.6-10-gc05b1cd

by Werner Koch cvs at cvs.gnupg.org
Tue Dec 1 13:07:07 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The standard pinentry collection".

The branch, master has been updated
       via  c05b1cd8aa4400cab9b315a6a55351dc95e0f929 (commit)
       via  bd3781f92bb0989bfbc33a89fe1f6db3c89cdf31 (commit)
      from  999162e7c38d4b8c76270e7b6790417fd6439ef3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c05b1cd8aa4400cab9b315a6a55351dc95e0f929
Author: Werner Koch <wk at gnupg.org>
Date:   Tue Dec 1 13:01:29 2015 +0100

    doc: Add a note about translated strings in Pinentry.
    
    --
    Suggested-by: Daniel Kahn Gillmor

diff --git a/doc/HACKING b/doc/HACKING
index 2f6dc69..f48721e 100644
--- a/doc/HACKING
+++ b/doc/HACKING
@@ -21,3 +21,18 @@
   in a "real" ChangeLog file, but keep the maximum line length at 72
   or smaller, so that the generated ChangeLog lines, each with its
   leading TAB, will not exceed 80 columns.
+
+  For more infomration please check the HACHING file from the GnuPG
+  project.
+
+* String translation
+
+  Pinentry does not not require any translation files because it
+  expects that all strings are provided localized by the caller.  This
+  is due to the design constraint to keep the tool simple and also to
+  make sure that translations match those of GnuPG.
+
+  The available translated strings can be found in GnuPG, file
+  agent/call-pinentry, function start_pinentry.  If a string is not
+  available the Pinentry code uses a default as a fallback.  However,
+  it is highly suggested to provide Pinentry with translated strings.

commit bd3781f92bb0989bfbc33a89fe1f6db3c89cdf31
Author: Werner Koch <wk at gnupg.org>
Date:   Tue Dec 1 12:54:38 2015 +0100

    Remove unused code.
    
    * secmem/util.c (lower_privs, raise_privs): Remove commented
    functions.

diff --git a/secmem/util.c b/secmem/util.c
index a47164a..31bea01 100644
--- a/secmem/util.c
+++ b/secmem/util.c
@@ -41,7 +41,7 @@ static uid_t real_uid, file_uid;
 
 /* Write DATA of size BYTES to FD, until all is written or an error
    occurs.  */
-ssize_t 
+ssize_t
 xwrite(int fd, const void *data, size_t bytes)
 {
   char *ptr;
@@ -68,7 +68,7 @@ xwrite(int fd, const void *data, size_t bytes)
 #if 0
 extern int debug;
 
-int 
+int
 debugmsg(const char *fmt, ...)
 {
   va_list va;
@@ -88,7 +88,7 @@ debugmsg(const char *fmt, ...)
 
 /* initialize uid variables */
 #ifndef HAVE_DOSISH_SYSTEM
-static void 
+static void
 init_uids(void)
 {
   real_uid = getuid();
@@ -98,42 +98,8 @@ init_uids(void)
 #endif
 
 
-#if 0 /* Not used. */
-/* lower privileges to the real user's */
-void 
-lower_privs()
-{
-  if (!uid_set)
-    init_uids();
-  if (real_uid != file_uid) {
-#ifdef HAVE_SETEUID
-    if (seteuid(real_uid) < 0) {
-      perror("lowering privileges failed");
-      exit(EXIT_FAILURE);
-    }
-#else
-    fprintf(stderr, _("Warning: running q-agent setuid on this system is dangerous\n"));
-#endif /* HAVE_SETEUID */
-  }
-}
-#endif /* if 0 */
-
-#if 0 /* Not used. */
-/* raise privileges to the effective user's */
-void 
-raise_privs()
-{
-  assert(real_uid >= 0);	/* lower_privs() must be called before this */
-#ifdef HAVE_SETEUID
-  if (real_uid != file_uid && seteuid(file_uid) < 0) {
-   perror("Warning: raising privileges failed");
-  }
-#endif /* HAVE_SETEUID */
-}
-#endif /* if 0 */
-
 /* drop all additional privileges */
-void 
+void
 drop_privs()
 {
 #ifndef HAVE_DOSISH_SYSTEM

-----------------------------------------------------------------------

Summary of changes:
 doc/HACKING   | 15 +++++++++++++++
 secmem/util.c | 42 ++++--------------------------------------
 2 files changed, 19 insertions(+), 38 deletions(-)


hooks/post-receive
-- 
The standard pinentry collection
http://git.gnupg.org




More information about the Gnupg-commits mailing list