[git] GnuPG - branch, master, updated. gnupg-2.1.10-25-gd40975c

by NIIBE Yutaka cvs at cvs.gnupg.org
Mon Dec 14 06:43:05 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU Privacy Guard".

The branch, master has been updated
       via  d40975cbe8ff86fcc4a1b4963fdffc66ddee85ce (commit)
      from  4d3395ef1fcde0b8c454c09956863959d590ede6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d40975cbe8ff86fcc4a1b4963fdffc66ddee85ce
Author: NIIBE Yutaka <gniibe at fsij.org>
Date:   Mon Dec 14 14:37:18 2015 +0900

    scd: Fix regression for generating RSA keys on card.
    
    * scd/app-openpgp.c (do_genkey): Strip leading zeros for fingerprint
    computation.
    
    --
    
    This bug is difficult to reproduce because the probability is 1/256,
    and key generation takes long time.  The regression was introduced
    when we add the support for ECC.
    
    GnuPG-bug-id: 2150

diff --git a/scd/app-openpgp.c b/scd/app-openpgp.c
index 581c5dd..92330ec 100644
--- a/scd/app-openpgp.c
+++ b/scd/app-openpgp.c
@@ -3623,6 +3623,11 @@ do_genkey (app_t app, ctrl_t ctrl,  const char *keynostr, unsigned int flags,
   send_status_info (ctrl, "KEY-CREATED-AT",
                     numbuf, (size_t)strlen(numbuf), NULL, 0);
 
+  for (; mlen && !*m; mlen--, m++) /* strip leading zeroes */
+    ;
+  for (; elen && !*e; elen--, e++) /* strip leading zeroes */
+    ;
+
   rc = store_fpr (app, keyno, (u32)created_at, fprbuf, PUBKEY_ALGO_RSA,
                   m, mlen, e, elen);
   if (rc)

-----------------------------------------------------------------------

Summary of changes:
 scd/app-openpgp.c | 5 +++++
 1 file changed, 5 insertions(+)


hooks/post-receive
-- 
The GNU Privacy Guard
http://git.gnupg.org




More information about the Gnupg-commits mailing list