[git] KSBA - branch, master, updated. libksba-1.3.5-11-ga1d9b04

by Kai Michaelis cvs at cvs.gnupg.org
Tue Aug 15 16:33:01 CEST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "KSBA is a library to access X.509 certificates and CMS data.".

The branch, master has been updated
       via  a1d9b046aec8cedda16a9e24eb8d2ed021f68d5d (commit)
      from  39e633d6d224cafa83d884865ac4e372709d91b7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1d9b046aec8cedda16a9e24eb8d2ed021f68d5d
Author: Kai Michaelis <kai at gnupg.org>
Date:   Tue Aug 15 16:30:04 2017 +0200

    Fix memory leaks in ksba_cms_identify and tests.
    
    * tests/t-reader.c: free prepend_srcdir() result.
    * tests/t-cms-parser: ditto & release writer instance.
    * src/cms.c: fix mem leak in ksba_cms_identify().

diff --git a/src/cms.c b/src/cms.c
index 57927a3..8d80464 100644
--- a/src/cms.c
+++ b/src/cms.c
@@ -435,6 +435,7 @@ ksba_cms_identify (ksba_reader_t reader)
       if (!strcmp (content_handlers[i].oid, oid))
         break;
     }
+  ksba_free(oid);
   if (!content_handlers[i].oid)
     return KSBA_CT_NONE; /* unknown */
   if (maybe_p12 && (content_handlers[i].ct == KSBA_CT_DATA
diff --git a/tests/t-cms-parser.c b/tests/t-cms-parser.c
index 6ece100..4b83dd7 100644
--- a/tests/t-cms-parser.c
+++ b/tests/t-cms-parser.c
@@ -220,6 +220,7 @@ one_file (const char *fname)
     }
 
   ksba_cms_release (cms);
+  ksba_writer_release (w);
   ksba_reader_release (r);
   fclose (fp);
 }
@@ -233,7 +234,12 @@ main (int argc, char **argv)
   if (argc > 1)
     one_file (argv[1]);
   else
-    one_file (prepend_srcdir ("extra/dsig-with-id-aa-encrypKeyPref-1.cms"));
+    {
+      char *fname = prepend_srcdir ("extra/dsig-with-id-aa-encrypKeyPref-1.cms");
+
+      one_file (fname);
+      free(fname);
+    }
   /*one_file ("pkcs7-1.ber");*/
   /*one_file ("root-cert-2.der");  should fail */
 
diff --git a/tests/t-reader.c b/tests/t-reader.c
index 2b6a40c..c4e7765 100644
--- a/tests/t-reader.c
+++ b/tests/t-reader.c
@@ -189,9 +189,12 @@ main (int argc, char **argv)
 {
   if (argc == 1)
     {
-      test_fd (prepend_srcdir ("cert_g10code_test1.der"));
-      test_file (prepend_srcdir ("cert_g10code_test1.der"));
-      test_mem (prepend_srcdir ("cert_g10code_test1.der"));
+      char *fname = prepend_srcdir ("cert_g10code_test1.der");
+
+      test_fd (fname);
+      test_file (fname);
+      test_mem (fname);
+      free(fname);
     }
   else
     {

-----------------------------------------------------------------------

Summary of changes:
 src/cms.c            | 1 +
 tests/t-cms-parser.c | 8 +++++++-
 tests/t-reader.c     | 9 ++++++---
 3 files changed, 14 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
KSBA is a library to access X.509 certificates and CMS data.
http://git.gnupg.org




More information about the Gnupg-commits mailing list