[git] GnuPG - branch, master, updated. gnupg-2.1.18-31-g1ec7dc4

[by Werner Koch]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The GNU Privacy Guard".

The branch, master has been updated
       via  1ec7dc4e55a9eb84161ce42797924c2f928e2a8e (commit)
      from  2a025039c1817c7f75c35a898884849a8e5dc926 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1ec7dc4e55a9eb84161ce42797924c2f928e2a8e
Author: Werner Koch <wk at gnupg.org>
Date:   Mon Jan 30 12:07:46 2017 +0100

    Explain commit e175152ef7515921635bf1e00383e812668d13fc.
    
    --

diff --git a/agent/cache.c b/agent/cache.c
index 2483682..4cb158c 100644
--- a/agent/cache.c
+++ b/agent/cache.c
@@ -481,7 +481,15 @@ agent_store_cache_hit (const char *key)
   /* To make sure the update is atomic under the non-preemptive thread
    * model, we must make sure not to surrender control to a different
    * thread.  Therefore, we avoid calling the allocator during the
-   * update.  */
+   * update.
+   *
+   * Background: xtrystrdup uses gcry_strdup which may use the secure
+   * memory allocator of Libgcrypt.  That allocator takes locks and
+   * since version 1.14 libgpg-error is nPth aware and thus talking a
+   * lock may now lead to thread switch.  Note that this only happens
+   * when secure memory is allocated, the standard allocator uses
+   * malloc which is not nPth aware.
+   */
   new = key ? xtrystrdup (key) : NULL;
 
   /* Atomic update.  */

-----------------------------------------------------------------------

Summary of changes:
 agent/cache.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
The GNU Privacy Guard
http://git.gnupg.org