gpg --edit, delsigs and --no-tty

[David Shaw]

On Sat, Oct 02, 2004 at 07:11:31PM +0200, Peter Palfrader wrote:

> | Command> delsig
> | uid  Ben Laurie <ben at thebunker.net>
> | sig:!::1:2719AF354042FFA0:1078132640:0::::13x
>            ^^^^^^^^
> | Delete this good signature? (y/N/q)n
> | uid  Ben Laurie <ben at thebunker.net>
> | sig:!::17:94C09C7F40CB7145:1087074629:0::::13x
>             ^^^^^^^^
> | Delete this good signature? (y/N/q)
> 
> It seems the long keyids are wrong tho.  The first 8 digits are the
> short keyid, the other 8 digits, I don't know.

Well, you win the prize for 'first bug found in 1.3.90'.  Here's a
patch.

David
-------------- next part --------------
Index: keyedit.c
===================================================================
RCS file: /cvs/gnupg/gnupg/g10/keyedit.c,v
retrieving revision 1.145
diff -u -r1.145 keyedit.c
--- keyedit.c	29 Sep 2004 17:41:58 -0000	1.145
+++ keyedit.c	2 Oct 2004 19:40:58 -0000
@@ -167,7 +167,7 @@
   if( sigrc != '?' || print_without_key )
     {
       printf("sig:%c::%d:%08lX%08lX:%lu:%lu:",
-	     sigrc,sig->pubkey_algo,(ulong)sig->keyid[1],(ulong)sig->keyid[2],
+	     sigrc,sig->pubkey_algo,(ulong)sig->keyid[0],(ulong)sig->keyid[1],
 	     (ulong)sig->timestamp,(ulong)sig->expiredate);
 
       if(sig->trust_depth || sig->trust_value)