assuan_inquire_ext_cb() and return value

Ben Kibbey bjk at luxsci.net
Sat Nov 17 17:37:56 CET 2007


Would it be better to set the return value of _assuan_inquire_ext_cb()
to the return value of the callback? If the callback fails for some
reason, the inquire still succeeds.

Index: assuan-inquire.c
===================================================================
--- assuan-inquire.c	(revision 277)
+++ assuan-inquire.c	(working copy)
@@ -324,7 +324,7 @@
 	ctx->inquire_membuf = NULL;
       }
     ctx->in_inquire = 0;
-    (ctx->inquire_cb) (ctx->inquire_cb_data, rc, buf, buf_len);
+    rc = (ctx->inquire_cb) (ctx->inquire_cb_data, rc, buf, buf_len);
   }
   return rc;
 }

-- 
Benjamin J. Kibbey bjk at luxsci.net/jabber/freenode
3019 F5FC AA33 5BC7 BE9F 09D2 393E DBD2 40D5 FA7E



More information about the Gnupg-devel mailing list