Patch to improve the pinentry quality bar

Bernhard Herzog bh at
Mon Nov 19 15:00:22 CET 2007

On Monday 19 November 2007 11:01, Werner Koch wrote:
> On Fri, 16 Nov 2007 19:13, bernhard.herzog at said:
> >  - Translate the texts introduced by the patch.
> Well, we can't use gettext because all user visible strings are set by
> the caller or default to GTK+ defaults.  However this requirement does
> nicely along with your other suggestion.  I'll take care of it.

I tested the new SVN version (rev. 171) briefly.  As you noted in the commit 
message, the Qt pinentry crashes.  The patch below fixes that.  With the 
patch the qt version works fine and setting the quality bar label and tooltip 
also works in both the gtk2 and qt pinentries.  Here's the patch:

Index: qt/pinentrydialog.cpp
--- qt/pinentrydialog.cpp	(revision 171)
+++ qt/pinentrydialog.cpp	(working copy)
@@ -62,7 +62,7 @@
   if (enable_quality_bar)
-      QLabel* _quality_bar_label = new QLabel( this );
+      _quality_bar_label = new QLabel( this );
       _quality_bar_label->setAlignment( Qt::AlignRight | Qt::AlignVCenter );
       grid->addWidget ( _quality_bar_label, 1, 0 );
       _quality_bar = new QProgressBar( this );

I noticed a few typos in rev. 171:

--- trunk/doc/pinentry.texi     2007-09-18 17:52:39 UTC (rev 170)
+++ trunk/doc/pinentry.texi     2007-11-19 12:36:53 UTC (rev 171)
@@ -288,6 +288,11 @@
   S: OK
 @end example
+If a custom laber for the auality bar is required, just add that label
+as an argument as precent escaped string.  You will need this feature to

This should read as follows, I think:

If a custom label for the quality bar is required, just add that label
as an argument as percent escaped string.  You will need this feature to



Bernhard Herzog                              Intevation GmbH, Osnabrück
Amtsgericht Osnabrück, HR B 18998   
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/attachments/20071119/e124d7d5/attachment.pgp 

More information about the Gnupg-devel mailing list