pinentry-curses and pinpad entry

[NIIBE Yutaka]

On 2011-12-05 at 11:01 +0900, NIIBE Yutaka wrote:
> When using pinpad entry, GnuPG invokes pinentry and then kill it.
> 
> It's OK killing pinentry program when it's GUI, but when it runs
> on terminal, the terminal remains cbreak an noecho mode.

I committed following fix to master branch.

diff --git a/agent/call-pinentry.c b/agent/call-pinentry.c
index d0cfd2b..36093bb 100644
--- a/agent/call-pinentry.c
+++ b/agent/call-pinentry.c
@@ -1273,8 +1273,7 @@ agent_popup_message_stop (ctrl_t ctrl)
         assuan_set_flag (entry_ctx, ASSUAN_NO_WAITPID, 1);
     }
   else if (pid > 0)
-    kill (pid, SIGKILL);  /* Need to use SIGKILL due to bad
-                             interaction of SIGINT with Pth. */
+    kill (pid, SIGINT);
 #endif
 
   /* Now wait for the thread to terminate. */


I believe that this fix is correct, but I think that it would cause
a problem on Windows.

Can we let pinentry finish by sending SIGINT on Windows?  If not, we
need to fix pinentry.

Could someone please test pinentry on Windows?
--