[PATCH 0/2] gitignore and string.h updates for GPGME

[Werner Koch]

Hi!
On Thu, 12 Apr 2012 19:51, wking at drexel.edu said:
> While I'm waiting for the go-ahead for more major socket changes to
> GPGME, here are a few more minor cleanups.  I think I got the ChangeLog
> commit message format right this time ;).

Kind of:

    * .gitignore: ignore object files and libtool files.  Move
    subdir-specific rules to subdir-specific .gitignores.

That one is fine.

    * doc/.gitignore, lang/cl/.gitignore, src/.gitignore,
    tests/.gitignore, tests/gpg/.gitignore, tests/gpgsm/.gitignore,
    tests/opassuan/.gitignore: Add subdir-specific ignore rules, so `git
    status` can focus on interesting changes.
   
According to the GNU standards, this should be:

    * doc/.gitignore, lang/cl/.gitignore, src/.gitignore
    * tests/.gitignore, tests/gpg/.gitignore, tests/gpgsm/.gitignore
    * tests/opassuan/.gitignore: Add subdir-specific ignore rules, so `git
    status` can focus on interesting changes.

The backticks are a nice idea, but $(git status) is more POSIXly ;-).

Two more comments:

.gitignore is nothing really important and will even not be distributed
in a tarball.  Thus I would not mention them at all in the ChangeLog.  I
would have used this commit message:

    flesh out rules and add subdirectory-.gitignores.

    --
    If you feel like explaining it, do it here.  Everything after
    the tearoff line won't be copied to the CHnageLog.  If the tear-off
    line is the first in the body, no entry will be created at all.


I also prefer to have just one .gitignore in the top directory.  The
reason why you need the new items is that you don't do a VPATH build.
Marcus and me prefer VPATH builds, because they keep the source
directory clean and best of all, you can do several build using
different configure options.  For example, I have one work directory and
several build directories:

  cd ~/b/gnupg
  ~/w/gnupg/configure .....
  make
  cd ~/b-w32/gnupg
  ~/w/gnupg/autogen.sh --build-w32
  make
  cd ~/b-w32ce/gnupg
  ~/w/gnupg/autogen.sh --build-w32ce
  make

It is also possible to keep build directores for other branches, like

  cd ~/b/gnupg-2.0
  ~/w/gnupg/configure .....
  make

Nevertheless, havig rules for non-VPATH buils in .gitignore is fine.


I applied :status-table.c: include string.h for strcmp.".


Salam-Shalom,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.