[PATCH] gpg-agent: fix lc-messages handling not to change Xauthority setting

Jim Meyering jim at meyering.net
Sat Jan 14 22:22:01 CET 2012


Hi Werner,

Coverity spotted the missing break.
This one is clearly legitimate:

>From d270326fb3f7ad86470e85b2aaa3b06cdf2aaddf Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Sat, 14 Jan 2012 22:20:39 +0100
Subject: [PATCH] gpg-agent: fix lc-messages handling not to change Xauthority
 setting

* agent/gpg-agent.c (main): Supply omitted "break" statement for
lc-messages option.  Otherwise, control would fall through to the
following oXauthority case and use the same value there.
---
 agent/gpg-agent.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/agent/gpg-agent.c b/agent/gpg-agent.c
index 63f4ba2..c264ba3 100644
--- a/agent/gpg-agent.c
+++ b/agent/gpg-agent.c
@@ -817,6 +817,7 @@ main (int argc, char **argv )
         case oTTYtype: default_ttytype = xstrdup (pargs.r.ret_str); break;
         case oLCctype: default_lc_ctype = xstrdup (pargs.r.ret_str); break;
         case oLCmessages: default_lc_messages = xstrdup (pargs.r.ret_str);
+          break;
         case oXauthority: default_xauthority = xstrdup (pargs.r.ret_str);
           break;

--
1.7.9.rc1.2.gccfe4



More information about the Gnupg-devel mailing list