[gnupg-devel] gnupg-2.0.19: common/estream.c mixes void and int

[Nelson H. F. Beebe]

While builds of gnupg-2.0.19 were successful on most of my roughly
25 flavors of Unix, compilations fail on two Solaris Intel systems.
The cause appears to be mixing of void and int in the file
common/estream.c in the definitions of the macros
ESTREAM_MUTEX_LOCK() .. ESTREAM_MUTEX_INITIALIZE() in
lines 177--188.

In function es_ftrylockfile() at line 2619, the value of
ESTREAM_TRYLOCK() is returned as an int, but a void cannot
be cast to an int.

Another minor problem is that configure.ac at line 1473 says

*** It is now required to build with support for the
*** GNU Portable Threads Library (Pth).

However, running 

% ./configure --help | grep pth
  --with-pth-prefix=PFX   prefix where GNU Pth is installed (optional)

says that Pth is optional.  Either it is optional, or it is
required, but only one can be true.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe at math.utah.edu  -
- 155 S 1400 E RM 233                       beebe at acm.org  beebe at computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------