subkey binding signature with no usage flags and/or a critical notation

[Daniel Kahn Gillmor]

On Tue 2013-03-19 11:25:25 -0400, Daniel Kahn Gillmor wrote:

> On 03/19/2013 10:52 AM, Werner Koch wrote:
>> On Fri, 15 Mar 2013 21:34, dkg at fifthhorseman.net said:
>>> My patch was just removing 3 lines ( ~ 30 bytes ) from
>>> do_add_key_flags() in g10/keygen.c -- i don't see any sort of copyright
>>> pertaining at all, but i'm fine waiting if you want me to wait.
>> 
>> Okay, send again.
>
> it's attached to this mail.

--- a/g10/keygen.c
+++ b/g10/keygen.c
@@ -210,9 +210,6 @@
     if (use & PUBKEY_USAGE_AUTH)
         buf[0] |= 0x20;
 
-    if (!buf[0])
-        return;
-
     build_sig_subpkt (sig, SIGSUBPKT_KEY_FLAGS, buf, 1);
 }

I don't think the above patch (to enable creation of a subkey with a
usage flags subpacket, but no usage flags set) was ever applied to
either the 1.4 or 2.0 branches -- is this something you would be OK
adding to a stable branch, or is it only going to be in 2.1/master?

thanks,

        --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 965 bytes
Desc: not available
URL: </pipermail/attachments/20130910/4a52630d/attachment-0001.sig>