[PATCH 1/4] * Remove un-needed check. If 'url' were not to be true, http_parse_uri(parse_uri(do_parse_uri))) would fail, leaving 'err' false.

Werner Koch wk at gnupg.org
Mon Dec 22 12:22:07 CET 2014


On Sun, 21 Dec 2014 19:21, git at internot.info said:

> -  if (err && url && !strncmp (url, "https:", 6))
> +  if (err && !strncmp (url, "https:", 6))

Well, URL is a fucntion argument and may be NULL.  However, the later
http_open_document would segv on NULL for URL thus the check above is
not sufficient.  For robustness I'll add a check for URL not beein NULL.


Salam-Shalom,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gnupg-devel mailing list