[PATCH] avoid double-close in unusual dotlock situations

Werner Koch wk at gnupg.org
Mon Dec 22 13:05:25 CET 2014


On Fri, 19 Dec 2014 23:12, dkg at fifthhorseman.net said:

>  close() should not be retried after an EINTR since this  may
>        cause a reused descriptor from another thread to be closed.

Actually that is a pretty unusal behaviour for an interrupted system
call.  But close is special anyway.  I was not aware of that and Jim
didn't mentioned that in

 https://www.gnu.org/ghm/2011/paris/slides/jim-meyering-goodbye-world.pdf

but okay, that was just about stdio.

Anyway, fix pushed and I will also backport it to the other branches.


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gnupg-devel mailing list