[PATCH 1/2] avoid duplicate declarationof sk-comments and no-sk-comments noops

Daniel Kahn Gillmor dkg at fifthhorseman.net
Mon Sep 29 23:49:52 CEST 2014


* g10/gpg.c: cleanup argument parsing

--

With c76117f8b0165fe5cec5e7f234f55f5a4cd7f0ab, the GnuPG 2.0.x branch
accidentally introduced a second (identical) argument parser for both
--sk-comments, and for --no-sk-comments.

This caused short versions (e.g. omitting the trailing "s", as gpgme
does) of either command to fail with:

   gpg: option "--sk-comment" is ambiguous
---
 g10/gpg.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/g10/gpg.c b/g10/gpg.c
index 12d4295..eefd4ae 100644
--- a/g10/gpg.c
+++ b/g10/gpg.c
@@ -538,9 +538,6 @@ static ARGPARSE_OPTS opts[] = {
   ARGPARSE_s_i (oAttributeFD, "attribute-fd", "@"),
   ARGPARSE_s_s (oAttributeFile, "attribute-file", "@"),
 
-  ARGPARSE_s_n (oNoop, "sk-comments", "@"),
-  ARGPARSE_s_n (oNoop, "no-sk-comments", "@"),
-
   ARGPARSE_s_i (oCompletesNeeded, "completes-needed", "@"),
   ARGPARSE_s_i (oMarginalsNeeded, "marginals-needed", "@"),
   ARGPARSE_s_i (oMaxCertDepth,	"max-cert-depth", "@" ),
-- 
2.1.0




More information about the Gnupg-devel mailing list