[PATCH] Check the return value when starting gpg.

Ben Kibbey bjk at luxsci.net
Wed Aug 12 12:45:18 CEST 2015

On Wed, Aug 12, 2015 at 08:14:00AM +0200, Werner Koch wrote:
> On Tue, 11 Aug 2015 03:26, bjk at luxsci.net said:
> > * src/engine-gpg.c (gpg_decrypt, gpg_delete, gpg_passwd): Check return
> > value of start().
> Thanks.  Any special reason why you did not changed this for gpg_sign()
> too?

None other than I overlooked it. :)

> I wonder why Marcus checked the return value only on some invocations
> when he chnaged the code in 2003.

Not sure. But when stress testing I'm getting crashes in
_gpgme_io_select() so there may be a race condition which may be related
to the FIXME's in start(). Without returning an error from start() it
gets stuck in a _gpgme_io_select() loop.

Ben Kibbey

More information about the Gnupg-devel mailing list