[PATCH 11/13] curl-shim: clean up varargs

Daniel Kahn Gillmor dkg at fifthhorseman.net
Sun Feb 22 05:10:35 CET 2015


* keyserver/curl-shim.c (curl_easy_setopt) : ensure that va_end is
  called.

--

stdarg(3) says:
      Each invocation of va_start() must be matched by a
      corresponding invocation of va_end() in the same function.

Observed by Joshua Rogers <honey at internot.info>

Debian-Bug-Id: #773475

[dkg: rebased to STABLE-BRANCH-1-4]
Signed-off-by: Daniel Kahn Gillmor <dkg at fifthhorseman.net>
---
 keyserver/curl-shim.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/keyserver/curl-shim.c b/keyserver/curl-shim.c
index ce510cb..72c0f04 100644
--- a/keyserver/curl-shim.c
+++ b/keyserver/curl-shim.c
@@ -155,6 +155,8 @@ curl_easy_setopt(CURL *curl,CURLoption option,...)
       break;
     }
 
+  va_end(ap);
+
   return handle_error(curl,CURLE_OK,NULL);
 }
 
-- 
2.1.4




More information about the Gnupg-devel mailing list