[PATCH 1/4] pinentry-tty: handle designated tty outside of read_password
Neal H. Walfield
neal at walfield.org
Fri May 1 20:43:56 CEST 2015
I've now pushed your four patches. Thanks for the fixes!
At Thu, 30 Apr 2015 09:54:06 -0400,
Daniel Kahn Gillmor wrote:
> On Thu 2015-04-30 07:49:09 -0400, Neal H. Walfield wrote:
> > I had a bit of trouble applying them to git head (due to differing
> > white space). What version did you base these patches on?
> For me, they apply directly atop
> 9d2d8b6bfaf2d5b07e7fb5be7188516e4158ed98, which is what i see as the
> main "master" branch at git://git.gnupg.org/pinentry.git. I just tested
> that by piping each e-mail message through "git am" in sequence after
> that commit.
I also used git am and it complained about some whitespace issues.
> You can also see these changes on the "tty-refactor" branch at:
> If you'd prefer to see the changes in some other form, please let me
> know what is most convenient for you.
Personally, I prefer pulling from a git repo. But, if it's not any
trouble, feel free to also send the patches to this list in this
format for the record. I don't know what Werner prefers. If he
doesn't like this suggestion, then he's welcome to chime in :).
> > Also, you didn't update the copyright header. I'll fit this for you.
> > What's appropriate here?
> Thanks! I think you're asking about attribution, so: you can credit the
> changes to Daniel Kahn Gillmor <dkg at fifthhorseman.net>. If you're
> asking for some other detail, please let me know.
I think I meant copyright. I've added the following header to the
file you modified:
Copyright (C) 2015 Daniel Kahn Gillmor <dkg at fifthhorseman.net>
More information about the Gnupg-devel