puts ("- gpg control packet")
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Thu May 7 21:18:22 CEST 2015
I just noticed that g10/parse-packet.c contains a single call to puts()
that seems pretty out of place:
de5070ca (Werner Koch 2006-07-27 14:18:55 +0000 2906) goto skipit; /* Definitely too large. We skip it to avoid an
de5070ca (Werner Koch 2006-07-27 14:18:55 +0000 2907) overflow in the malloc. */
72503314 (Repo Admin 2003-06-05 07:14:21 +0000 2908) if (list_mode)
72503314 (Repo Admin 2003-06-05 07:14:21 +0000 2909) puts ("- gpg control packet");
72503314 (Repo Admin 2003-06-05 07:14:21 +0000 2910)
c0c2c580 (Werner Koch 2003-06-18 19:56:13 +0000 2911) packet->pkt.gpg_control = xmalloc (sizeof *packet->pkt.gpg_control
72503314 (Repo Admin 2003-06-05 07:14:21 +0000 2912) + pktlen - 1);
the git blame output above makes it look like it was introduced during
the branch to 1.9 -- maybe it goes back a long way. is there a reason
this is here?
it sends this line of data to stdout when i run "gpg -vvvvvv --verify"
on a clearsigned message, which is potentially confusing to processes
which are looking for anything in stdout.
--dkg
More information about the Gnupg-devel
mailing list