[PATCH] dirmngr: Fix t-http compile error

Daiki Ueno ueno at gnu.org
Tue Nov 10 02:34:23 CET 2015

Daiki Ueno <ueno at gnu.org> writes:

> * dirmngr/Makefile.am (t_http_CFLAGS): Add LIBASSUAN_CFLAGS.

I should have explain a bit more in detail (I thought it is obvious
enough for the developers to replicate the error).

The current git master doesn't compile on systems where assuan.h is not
installed in the standard include directory.  For example, Fedora
installs it in /usr/include/libassuan2:

  gcc -DHAVE_CONFIG_H -I. -I..  -I../common -DLOCALEDIR=\"/usr/local/share/locale\" -DGNUPG_BINDIR="\"/usr/local/bin\"" -DGNUPG_LIBEXECDIR="\"/usr/local/libexec\"" -DGNUPG_LIBDIR="\"/usr/local/lib/gnupg\"" -DGNUPG_DATADIR="\"/usr/local/share/gnupg\"" -DGNUPG_SYSCONFDIR="\"/usr/local/etc/gnupg\"" -DGNUPG_LOCALSTATEDIR="\"/usr/local/var\""        -DWITHOUT_NPTH=1 -g -O2 -O3 -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wformat -Wno-format-y2k -Wformat-security -W -Wno-sign-compare -Wno-missing-field-initializers -Wdeclaration-after-statement -Wno-pointer-sign -Wpointer-arith -MT t_ldap_parse_uri-http.o -MD -MP -MF .deps/t_ldap_parse_uri-http.Tpo -c -o t_ldap_parse_uri-http.o `test -f 'http.c' || echo './'`http.c
  http.c:97:56: fatal error: assuan.h: No such file or directory
  compilation terminated.

I am attaching a slightly modified patch, since I noticed that it is
also the case for t-ldap-parse-uri.

Werner Koch <wk at gnupg.org> writes:

> On Sun,  1 Nov 2015 03:35, ueno at gnu.org said:
>> To reduce build time, defer compilation of test programs to the "make
>> check" phase.
> I don think this is useful:
> "make check" is only rarely run in contrast to "make".  Thus always
> building the test programs helps finding build problems early.

About the development policy, I defer to you, of course.  However, such
build problems could also be observed by building the main programs (the
"dirmngr" executable in this case)?  I was actually not interested in
compiling the dirmngr test programs and rather wanted to skip them.

Daiki Ueno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dirmngr-Fix-http.c-compilation-for-tests.patch
Type: text/x-patch
Size: 1701 bytes
Desc: not available
URL: </pipermail/attachments/20151110/55aaf2af/attachment.bin>

More information about the Gnupg-devel mailing list