gen-key with wrong passphrase

Werner Koch wk at gnupg.org
Tue Oct 6 20:53:26 CEST 2015


On Tue,  6 Oct 2015 20:29, gniibe at fsij.org said:

> In genkey.c, the function reenter_compare_cb can return -1.
> The value -1 is incompatible by the change of the commit efde50f92a.

Right.  I used -1 to make the functions similar to strcmp - but that is
not really required.

> I'm not sure how we fix this.  Shall we change the callback
> pininfo->check_cb return type from int to gpg_error_t?

That is a good idea.  I am not sure what error to return.  The new
GPG_ERR_FALSE seems to be best but we may need to also change the
callers to return a more descriptive error message.


Salam-Shalom,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gnupg-devel mailing list