[PATCH] ensure all weak digest rejection notices are shown

Daniel Kahn Gillmor dkg at fifthhorseman.net
Fri Oct 23 23:54:44 CEST 2015

On Fri 2015-10-23 17:46:57 -0400, Daniel Kahn Gillmor wrote:
> Previously, only one weak digest rejection message was shown, of
> whichever was the first type encountered.  This meant that if "gpg
> --weak-digest SHA224" encountered both an MD5 digest and a SHA224
> digest, it would only show the user that the MD5 digest was rejected.
> In order to let the user know which algorithms were rejected, we
> needed to move the "shown" flag into a per-weak-algorithm location.
> Given this additional complication, it made no sense to continue to
> treat MD5 specially, so it is added as a default weak algorithm in the
> same opt.weak_digests data structure as any other.

btw, sorry to dribble these changes in over the course of three patches
instead of one.  each successive patch addresses failings that i hadn't
noticed when i submitted the previous one.  I think this is the last of
them for this particular enhancement, but then again, that's what i
thought last time too :/


More information about the Gnupg-devel mailing list