[PATCH] tools/gpgconf.c (main): Initialize libgcrypt.

Justus Winter justus at g10code.com
Mon Aug 8 11:22:10 CEST 2016

Hello :)

Ben Kibbey <bjk at luxsci.net> writes:

> --
> Fixes a warning appearing the system logs when --homedir is passed.

I don't understand, what warning ends up in what log?  Also, please mind
our commit log guidelines, see doc/HACKING.

> @@ -229,6 +230,12 @@ main (int argc, char **argv)
>    i18n_init();
>    init_common_subsystems (&argc, &argv);
> +  if (!gcry_check_version (NEED_LIBGCRYPT_VERSION) )
> +    {
> +      log_fatal ( _("%s is too old (need %s, have %s)\n"), "libgcrypt",
> +                  NEED_LIBGCRYPT_VERSION, gcry_check_version (NULL) );
> +    }
> +

Hmm, as I see it, init_common_subsystems registers gcry_realloc as
allocation function for libgpg-error.  So shouldn't this check be
included before init_common_subsystems, or maybe even just moved to

Also, I don't like the 'function ( space, before, argument )' style, and
cursory grepping reveals that using 'function (no, space, before,
argument)' is more common in GnuPG.  At least please be consistent.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: </pipermail/attachments/20160808/d4303bf4/attachment.sig>

More information about the Gnupg-devel mailing list