[LIBGPG-ERROR PATCH] avoid whitespace in gpg-error.def linker script for mingw32

[Daniel Kahn Gillmor]

On Tue 2016-02-09 03:35:55 -0500, Werner Koch wrote:
> On Tue,  9 Feb 2016 05:42, dkg at fifthhorseman.net said:
>> When cross-building for Windows with ./configure --host
>> i686-w64-mingw32 on recent versions of debian, the library doesn't get
>> built properly because of a difference in the whitespace produced in
>> the library's .def linker script.
>
> I can't replicate this problem on Jessie.

hm, i haven't tried it on jessie, i've only tried it on
testing/unstable.

> Did you update libtool before building libgpg-error?

I did autoreconf the package, yes.  This is generally considered good
practice on debian for a number of reasons, many of which are described
here:

   https://wiki.debian.org/Autoreconf

> You should not do that - we patched the included libtool to fix a
> couple of problems.

Are these fixes documented or pushed upstream anywhere?  If they're
causing problems for GnuPG, we should get them upstreamed into libtool.

Similarly, GnuPG would benefit from being able to use the bugfixes that
made their way into upstream versions of libtool and other autotools
packages.

> Libtool for Windows is pretty fragile and replacing it may introduce
> new bugs.

i'm hoping that in debian we can have an automated system that finds
those bugs and reports them so that they can be fixed for everyone.
With the patch supplied, an autoreconf'ed libgpg-error can be built for
Windows directly from debian.  I plan to introduce autopkgtest rules as
well to ensure that the builds actually work (at least that they work
under wine, we don't have any sort of actual-MS-Windows CI set up within
debian).

The reason i care about this is that there is a variant of
debian-installer that runs on windows [0], and part of that installer is
a gpgv.exe that is used to verify files after the installer bootstrap.
I want to ensure that this tool can be built using modern versions of
GnuPG.  And of course, i want to ensure that it builds cleanly (and in
an automated fashion) on debian systems without the need for any
external process.

If the patch works to acheive this goal, you see any problem with it?

        --dkg

[0] https://packages.qa.debian.org/w/win32-loader.html