[PATCH] [RFC] Define lock-obj in gpg-error.h

[Werner Koch]

On Mon, 28 Mar 2016 11:13, joerg.krause at embedded.rocks said:

> 1) It relies on the toolchains triplet. The toolchain triplet has to match a

Right.  You need to use a recent config.sub to canonicalize the triplet.
For certain host values it is also possible to use the alias list in
mkheader.c

> 2) A toolchains triplet does not tell us about the builtin
> features. Consider a uClibc based toolchain named
> arm-unknown-linux-gnueabi was configured without thread support. Using

Thread support is part of the ABI.

> lock-obj instead of a dummy lock-obj.  3) Cross-compiling
> gen-posix-lock-obj and run it on the target to output a lock-obj file
> is an unnecessary step and can be easily avoided.

You are free to come up with the info by other means.

> lock-obj defined at compile-time, copying this lock-obj file to syscfg and have
> mkheader insert this information into gpg-error.h before compilation does the
> same as defining the lock-obj in gpg-error.h directly. The compilation units

See my reply to your other mail.


>  src/gpg-error.h.in | 63

> +#if HAVE_CONFIG_H
> +#include <config.h>
> +#endif

You MUST NOT put a config.h into a public header.  

> +# define USE_DOUBLE_FOR_ALIGNMENT 1

This macro name is not in libgpg-error's name space.


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.