[PATCH 1/8] tests/openpgp: add export-cleartext

Daniel Kahn Gillmor dkg at fifthhorseman.net
Wed May 25 17:47:08 CEST 2016

On Wed 2016-05-25 02:25:36 -0400, Werner Koch <wk at gnupg.org> wrote:
> On Tue, 24 May 2016 17:18, dkg at fifthhorseman.net said:
>> I've had no followup about this patch series yet -- is there a problem
>> with it, or something else i should be aware of?
> It is quite a lot of changes and I need some time to audit it.  I will
> probably suggest that you squash the patches into one or two only.

I broke the patches out into separate logical commits with the goal of
making the series of changes easier to audit and to understand the
workflow piece by piece.  (see also mjg's recent discussion about
piecewise, textbook commit history [0])

But if you prefer that the patches be squashed, i can of course do that.
If you want that, please let me know how you think the commits should be

> A signed off lines is also missing ;-)

whoops, i've historically thought that the Author: line was the
equivalent of that, but i see that doc/HACKING recommends it on a
per-commit basis.  I can re-send the patch series with signed-off-by
entries, if you prefer.

If these changes land, it should be pretty simple for me to restore the
export-reset-subkey-passwd flag.

Thanks reviewing!


[0] https://mjg59.dreamwidth.org/42759.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 948 bytes
Desc: not available
URL: </pipermail/attachments/20160525/827c837b/attachment.sig>

More information about the Gnupg-devel mailing list