[PATCH 2/5] dirmngr: hkp: avoid race condition when some hosts die

Daniel Kahn Gillmor dkg at fifthhorseman.net
Tue Nov 1 20:39:52 CET 2016


On Tue 2016-11-01 12:49:16 -0400, Werner Koch wrote:
> That is the whole point of using nPth or the older Pth.  You can
> implement most algorithms without thinking about multithreading as long
> as you avoid blocking system calls.

hm, interesting.  If you can avoid blocking system calls, you can get
the same benefit by just using an event-driven model, with no explicit
threads at all, right?

> In general I would like to postpone all these patches because they do
> not add required features or fixes.

It's not clear to me what features or fixes are required -- but i know
that i want to help people have a functional, smoothly-running system
that supports the modern GnuPG mini-server model without them noticing
the change.  Part of doing that is avoiding systems that are active when
they intend to be idle (which we've had complaints about), so i'm trying
to offer a fix for that on platforms and configurations that can easily
support it.

> We have a whole bunch of other topics to address in the next weeks and
> any other new code will only delay a release even more.

fwiw, this dirmngr series is not a lot of "new code".  rather, it's a
reduction (two patches in this series are simply dead code removal):

 dirmngr/dirmngr.c       | 156 ++----------------------------------------------
 dirmngr/dirmngr.h       |   4 --
 dirmngr/ks-engine-hkp.c |  94 ++++++++++++++---------------
 dirmngr/ldap-wrapper.c  |   7 ++-
 4 files changed, 55 insertions(+), 206 deletions(-)

I don't want these patches to get lost, and i'd love review.  however, i
don't know what the project's priorities are, so i'm not sure how to
make sure they don't fall off of the queue (i don't even know where the
queue is).

What do you recommend i do?

     --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 930 bytes
Desc: not available
URL: </pipermail/attachments/20161101/25c69fd3/attachment-0001.sig>


More information about the Gnupg-devel mailing list